1485577 - When Firefox Nightly has no windows, link text of other applications and .webloc file open a blank page of Firefox Nightly.

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Eiichi]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180822221004

Steps to reproduce:

1. Launch Firefox Nightly.
2. Close all windows.
3. Open .webloc file.


Actual results:

Firefox Nightly opens a blank page and URLbar is blank.


Expected results:

Firefox Nightly should open the web page designated by the webloc file.

Comment 1

[Eiichi]

When Firefox Nightly has no windows, link text by other applications (e.g. Mail.app) doesn't work.

Comment 2

[Eiichi]

Is this bug related to Bug 1484482?

Comment 3

[Mark Banner (:standard8)]

I just checked with mozregression and found this range:

 9:27.36 INFO: Last good revision: 3d50f935615c9ba9179e8ab0dbb244ca65626967
 9:27.36 INFO: First bad revision: 486f7f825c6bfb4b31cb76c49174f2880dd8af19
 9:27.36 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3d50f935615c9ba9179e8ab0dbb244ca65626967&tochange=486f7f825c6bfb4b31cb76c49174f2880dd8af19

Which points to:

Bug 1364392 - Provide correct triggeringPrincipal to openLinkIn r=Gijs 


We're hitting the newly added throw in utiltityOverlay.js (although unfortunately that message doesn't appear on the console).

When we hit loadURI here:

https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/browser/base/content/browser.js#1692

the window arguments are: [<url to load>, null, null, null]

So when this gets through to the openLinkIn call, there's no triggeringPrincipal, and so it doesn't load anything.

Comment 4

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
We need to not ship this.

Comment 5

[:Gijs (he/him)]

(In reply to Eiichi from comment #2)
> Is this bug related to Bug 1484482?

Based on the regression range, no, it isn't - the root causes are quite different.

Comment 6

[Jonathan Kingston [:jkt] he/him]

Looking into this.

Comment 7

[Jonathan Kingston [:jkt] he/him]

I created a patch however I will need someone to test it. This certainly looks like a fix for Bug 1485663 but I'm not sure if this is a fix here.

If you have time to build and test on Mac that would be great. (I requested a new loaner for the future).

Comment 8

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 63 since it's a recent regression.

Comment 10

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 9003506 [details]
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8

Jonathan Kingston [:jkt] has approved the revision.

Comment 11

[:Gijs (he/him)]

Stole this from jkt, so reflecting that in bugzilla as well.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 9003506 [details]
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8

Mark Banner (:standard8) has approved the revision.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f83d8d85c94f
Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8

Comment 14

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser/base/content/test/performance/browser_tabopen.js

Push that contains the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bbbab4206c4696bf21ae5e8b93f06bd38dd015b3

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195786732&repo=autoland&lineNumber=1969

Backout: https://hg.mozilla.org/integration/autoland/rev/9f0c56001fbffc0afe2eabffeb7b65b7139d56cd

Comment 15

[:Gijs (he/him)]

(In reply to Andreea Pavel [:apavel] from comment #14)
> Backed out for failing bc at
> browser/base/content/test/performance/browser_tabopen.js
> 
> Push that contains the failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=bbbab4206c4696bf21ae5e8b93f06bd38dd015b3
> 
> Failure log:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=195786732&repo=autoland&lineNumber=1969
> 
> Backout:
> https://hg.mozilla.org/integration/autoland/rev/
> 9f0c56001fbffc0afe2eabffeb7b65b7139d56cd

This was orange prior to my patch ( https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=195799305 ) and I can't reproduce locally. Are you sure you're backing out the right change?

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f84d024c27b5
Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8 on a CLOSED TREE

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f84d024c27b5