1485626 - Tab_Index reaches elements inside collapsed menus in activity stream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Maria Berlinger [:mberlinger], Services QA]

Attachment: Screencast 2018-08-23 14:26:17.mp4

[Affected versions]:
- latest Nightly 63.0a1 (2018-08-23)
- Beta 62.0b19 (BuildId 20180820172315)
- Release 61.0.2 (BuildId 20180807170231)

[Affected platforms]:
- Windows 10 64bit
- macOS 10.13
- Ubuntu 16.04 64bit

[Steps to reproduce]:
1. Launch Firefox.
2. Click the Top Sites title to collapse from A-S page.
3. Navigate with the tab key on the page until the three dots appear on right corner of the Top sties.
4. Press once again the tab key and press enter.

[Expected result]:
- The top sites are not selected.

[Actual result]:
- Top sites are selected even if they are collapsed.

[Regression range]:
- It doesn't seem to be a recent regression; I was able to reproduce it on 61.0.2 as well. I will investigate further in case on an old regression an provide more info.

[Additional notes]:
- see the attached screencast

Comment 1

[Maria Berlinger [:mberlinger], Services QA]

It seems that this issue is not a regression since I was able to reproduce this bug on Nightly ( 2017-10-07) when this feature (bug 1405539) was first implemented.

Comment 2

[Jenn Chaulk (:jchaulk)]

Hi Maria, the attachment is not working.  It says the file is corrupt.

Comment 3

[Maria Berlinger [:mberlinger], Services QA]

Attachment: bug.gif

I have uploaded again the attachment, I hope you can see it now.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4428

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/60d3ea91e82d06532184f42a2063e6875086f9cf
Fix Bug 1485626 - Tab_Index reaches elements inside collapsed menus in activity stream (#4428)

* Fix Bug 1485626 - Tab_Index reaches elements inside collapsed menus in activity stream

* fixes

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The issue is no longer reproducible on the latest Nightly 64.0a1 (Build ID 20180925220052) on Windows 10 x64, Mac 10.13.3 and Arch Linux x64.

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/95f8e6265f24

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

wfm? Don't think we need to uplift this.