Closed Bug 1485738 Opened 2 years ago Closed 2 years ago

Add column numbers to the JIT Spew

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

All
Unspecified
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: denispal, Assigned: denispal)

Details

Attachments

(1 file)

The gecko profiler now emits column numbers for JS functions in the profile.  We should add the same information in the JIT spew so that it's easier to match functions in minified scripts.
Assignee: nobody → dpalmeiro
Priority: -- → P3
It is currently quite difficult to debug minified scripts.  The JitSpew and profiler used to display only line numbers, so all of the output would be emitted as "script:1".  Column number information is now collected by the gecko profiler as of bug 785922.  The JitSpew should also emit column numbers so that it's easy to line up with the profiler output.
Comment on attachment 9005218 [details]
Bug 1485738: Add column number information to the JitSpew

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.
Attachment #9005218 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f831b709e37
Add column number information to the JitSpew r=mgaudet
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d438550d856
Add column number information to the JitSpew r=mgaudet
Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.
https://hg.mozilla.org/mozilla-central/rev/9d438550d856
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.