1485738 - Add column numbers to the JIT Spew

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Denis Palmeiro [:denispal]]

The gecko profiler now emits column numbers for JS functions in the profile.  We should add the same information in the JIT spew so that it's easier to match functions in minified scripts.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1485738: Add column number information to the JitSpew

It is currently quite difficult to debug minified scripts.  The JitSpew and profiler used to display only line numbers, so all of the output would be emitted as "script:1".  Column number information is now collected by the gecko profiler as of bug 785922.  The JitSpew should also emit column numbers so that it's easy to line up with the profiler output.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 9005218 [details]
Bug 1485738: Add column number information to the JitSpew

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f831b709e37
Add column number information to the JitSpew r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d438550d856
Add column number information to the JitSpew r=mgaudet

Comment 5

[Andreea Pavel [:apavel]]

Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d438550d856