Add column numbers to the JIT Spew

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: denispal, Assigned: denispal)

Tracking

Trunk
mozilla63
All
Unspecified
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
The gecko profiler now emits column numbers for JS functions in the profile.  We should add the same information in the JIT spew so that it's easier to match functions in minified scripts.
(Assignee)

Updated

6 months ago
Assignee: nobody → dpalmeiro
Priority: -- → P3
(Assignee)

Comment 1

6 months ago
Created attachment 9005218 [details]
Bug 1485738: Add column number information to the JitSpew

It is currently quite difficult to debug minified scripts.  The JitSpew and profiler used to display only line numbers, so all of the output would be emitted as "script:1".  Column number information is now collected by the gecko profiler as of bug 785922.  The JitSpew should also emit column numbers so that it's easy to line up with the profiler output.
Comment on attachment 9005218 [details]
Bug 1485738: Add column number information to the JitSpew

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.
Attachment #9005218 - Flags: review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed
(Assignee)

Updated

6 months ago
Keywords: checkin-needed
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 3

6 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f831b709e37
Add column number information to the JitSpew r=mgaudet
Keywords: checkin-needed

Comment 4

6 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d438550d856
Add column number information to the JitSpew r=mgaudet
Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d438550d856
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.