1485810 - LastPass, 1Password, Bitwarden and all 3rd-party password manager auto-fill is broken in Firefox for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

+++ This bug was initially created as a clone of Bug #1330257 +++

In Firefox 49, LastPass worked with Firefox for Android (albeit in a limited fashion, requiring you to copy/paste usernames/passwords, as opposed to them actually being filled in like with Chrome and other Android applications).

In Firefox 50, LastPass doesn't work at all. If you tap the LastPass notification, it just displays a toast that reads 'LastPass was unable to auto-fill this app'.

Putting this in Keyboards/IME but uncertain of the mechanism LastPass actually uses to auto-fill applications.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1485810 - 1. Move auto-fill code to GeckoViewAutoFill.jsm; r?droeh

Move all auto-fill code to GeckoViewAutoFill.jsm, so they can be shared
between GeckoView and Fennec.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1485810 - 2. Add GeckoViewAutoFill support in browser.js; r?petru

Make auto-fill work for the main Fennec activity by making calls to
GeckoViewAutoFill.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9005759 [details]
Bug 1485810 - 2. Add GeckoViewAutoFill support in browser.js; r?petru

Petru-Mugurel Lingurar[:petru] has approved the revision.

Comment 4

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 9005758 [details]
Bug 1485810 - 1. Move auto-fill code to GeckoViewAutoFill.jsm; r?droeh

Dylan Roeh (:droeh) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d59d980a5745
1. Move auto-fill code to GeckoViewAutoFill.jsm; r=droeh
https://hg.mozilla.org/integration/mozilla-inbound/rev/32efa2eb33bd
2. Add GeckoViewAutoFill support in browser.js; r=petru

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d59d980a5745
https://hg.mozilla.org/mozilla-central/rev/32efa2eb33bd

Comment 7

[Anatoly]

Question about this issue: In the current Aurora build, we can now see the individual fields inside the browser, but they are all the same size and position as the containing ViewGroup, which is causing problems with field classification. Will there be an update to correct this?

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Anatoly from comment #7)
> Question about this issue: In the current Aurora build, we can now see the
> individual fields inside the browser, but they are all the same size and
> position as the containing ViewGroup, which is causing problems with field
> classification. Will there be an update to correct this?

Thanks for the problem report! I filed new bug 1491989 to track this regression. If you have specific steps to reproduce or a link to a test case, please share it in that bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Did we want to let this ride the trains?

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

I think so, since this bug involves only Fennec.

Comment 11

[Sorina Florean [:sflorean]]

Tested on Nightly 64.0a1 with the following 3rd-party password managers: LastPass, 1Password, Bitwarden using the following devices: 
- Motorola Nexus 6(Android 7.1.1), 
- LG G4(Android 5.1),
- Sony Xperia Z5 Premium (Android 6.0.1).
I was able to log in on several sites (Twitter, Facebook) using 1Password and Bitwarden but with no success regarding LastPass. Tested also on Chrome to see if is some setting the problem but it worked just fine.

Comment 12

[Eitan Isaacson [:eeejay]]

Hey Anotoly,

The latest nightly build should be giving you real screen coordinates of the edit boxes. As Sorina says, we still can't get LastPass to work via the a11y api. Does this have to do with failed URL scraping from the toolbar?

In uitautomator I can see a TextView with an id of #PACKAGENAME#:id/url_bar_title with the text value being the current URL. Shouldn't that be enough?

Thanks!

Comment 13

[Anatoly]

Hi Eitan,

Our current production build does not support Nightly; I will email you a develop build for testing.

I have confirmed in uiautomatorviewer that the coordinates appear to be correct, and a11y autofill works. However it looks like the autofill framework is still not seeing coordinates, and pinning the autofill window to the bottom on Pie.

Thanks,
Anatoly

Comment 14

[Eitan Isaacson [:eeejay]]

Thanks Anatoly,

The autofill API has a different non-a11y implementation, so we will need to add coordinates there as well.