1492704 - Crash in java.lang.NullPointerException: at org.mozilla.geckoview.SessionTextInput.onProvideAutofillVirtualStructure(SessionTextInput.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is
report bp-846eff60-7103-40f7-b772-4be630180919.
=============================================================

Java stack trace:

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.mozilla.gecko.util.GeckoBundle.getInt(java.lang.String, int)' on a null object reference
	at org.mozilla.geckoview.SessionTextInput.onProvideAutofillVirtualStructure(SessionTextInput.java:516)
	at org.mozilla.geckoview.GeckoView.onProvideAutofillVirtualStructure(GeckoView.java:634)
	at android.view.View.dispatchProvideStructureForAssistOrAutofill(View.java:8210)
	at android.view.View.dispatchProvideAutofillStructure(View.java:8202)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3493)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510)
	at android.view.ViewGroup.dispatchProvideAutofillStructure(ViewGroup.java:3510)
	at android.app.assist.AssistStructure$WindowNode.<init>(AssistStructure.java:510)
	at android.app.assist.AssistStructure.<init>(AssistStructure.java:1912)
	at android.app.ActivityThread.handleRequestAssistContextExtras(ActivityThread.java:3133)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1899)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6753)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:482)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1492704 - 1. Update auto-fill then selecting tabs; r=petru

Update auto-fill info when selecting tabs. Also for auto-fill focus and
page events, only handle those events for the foreground tab, so
events from background tabs don't inadvertently affect auto-fill for the
foreground tab.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh

Don't update the focused node in the node cache during auto-fill focus
events, because we don't necessarily know if the focused node should be
in the node cahce (e.g. the focused node could be from another window
than the one we're handling currently).

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9011740 [details]
Bug 1492704 - 1. Update auto-fill then selecting tabs; r=petru

Petru-Mugurel Lingurar[:petru] has approved the revision.

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 9011741 [details]
Bug 1492704 - 2. Keep track of the auto-fill focus root node; r=droeh

Dylan Roeh (:droeh) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4e7fd47d96
1. Update auto-fill then selecting tabs; r=petru
https://hg.mozilla.org/integration/mozilla-inbound/rev/a44a660a1580
2. Don't update node during auto-fill focus event; r=droeh

Comment 7

[Chris Peterson [:cpeterson]]

Jim, do we need to uplift this auto-fill fix to GV 63 Beta or the GV 62 relbranch? The crash volume looks pretty low, though we don't have recent data for GV 62 because Focus 7.0 has temporarily disabled GV's Breakpad crash reporting.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bf4e7fd47d96
https://hg.mozilla.org/mozilla-central/rev/a44a660a1580

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Pretty sure this is specific to Fennec auto-fill (bug 1485810), so we can let it ride the trains on 64.

Comment 10

[Calixte Denizet (:calixte)]

There ~3000 crashes with this signature after the patch landed.
The signature is ranked #0 in nightly top-crashers.

Comment 11

[Calixte Denizet (:calixte)]

[Tracking Requested - why for this release]:
Crashes number is very high.

Comment 12

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1492704)by request of jcristau for causing multiple nightly crashes a=backout CLOSED TREE
Backout revision https://hg.mozilla.org/mozilla-central/rev/034d18f8ad947f9cc1e730f62ecaf5adfaac50ec
Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=be037b5b6327f423a45c50837de07bae9522bd9a

:jchen Could you please take a look?

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b49a74b30e6
1. Update auto-fill then selecting tabs; r=petru
https://hg.mozilla.org/integration/autoland/rev/538da6bb518b
2. Keep track of the auto-fill focus root node; r=droeh

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7b49a74b30e6
https://hg.mozilla.org/mozilla-central/rev/538da6bb518b