1485874 - Make hgmo extension compatible with Mercurial 4.7

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Description

[Connor Sheehan [:sheehan]]

Attachment: result of `./run-tests hgext/hgmo --with-hg=venv/mercurials/4.7/bin/hg`

The tests are failing under Mercurial 4.7. Looks like lots of work to do here. I've attached the logs separately as they are quite long.

Comment 1

[Gregory Szorc [:gps]]

I expect most issues with hgmo will be around templating in hgweb. Essentially, all data structures fed into the templating layer should be using wrapper types instead of e.g. straight lists.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: hgmo: wrap `csets` field as a `templateutil.mappinglist` (Bug 1485874) r?gps

I decided to just wrap the end list instead of making this a
generator as the command is legacy and it was faster.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: hgmo: get context using `scmutil` functions (Bug 1485874) r?gps

We use the `repo[x]` syntax in several places throughout the
hgmo extension. Using that syntax for certain use cases is
no longer supported. The recommended methods to use are found
in the `scmutil` module.

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: hgmo: remove unused variable (Bug 1485874) r?gps

Leftover from removing pre-4.6 compatibility code.

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: hgmo: add `automationrelevance` JSON template (Bug 1485874) r?gps

This commit adds an `automationrelevance` template to the `json`
template, allowing us to send the output of the `automationrelevance`
webcommand through the template layer instead of streaming
JSON directly. Due to this change, output from the raw
HTTP endpoint is no longer nicely indented. We now send the
response to a body file and then use `json.tool` to format
the output.

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: hgmo: create bugs, reviewers, backouts fields with generators (Bug 1485874) r?gps

This lets us pass them to the template layer as a `mappinggenerator`
and brings us closer to 4.7 compatibility.

Comment 7

[Connor Sheehan [:sheehan]]

Attachment: hgmo: send archives info to template layer in `repoinfo` webcommand (Bug 1485874) r?gps

The `repoinfo` HTML template needs the `archives` field to be
set to properly render the navbar on the page, yet we aren't
sending anything to the templater to display. Under Mercurial
4.7 this causes a 500 to be thrown, so let's send this now.

Comment 8

[Connor Sheehan [:sheehan]]

Attachment: hgmo: mark as compatible with Mercurial 4.7 (Bug 1485874) r?gps

After applying the series, we are compatible with Mercurial
4.7 on this extension.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 9011646 [details]
hgmo: wrap `csets` field as a `templateutil.mappinglist` (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 9011647 [details]
hgmo: get context using `scmutil` functions (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 9011648 [details]
hgmo: remove unused variable (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 12

[Gregory Szorc [:gps]]

Comment on attachment 9011649 [details]
hgmo: add `automationrelevance` JSON template (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 13

[Gregory Szorc [:gps]]

Comment on attachment 9011650 [details]
hgmo: create bugs, reviewers, backouts fields with generators (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 14

[Gregory Szorc [:gps]]

Comment on attachment 9011651 [details]
hgmo: send archives info to template layer in `repoinfo` webcommand (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 9011652 [details]
hgmo: mark as compatible with Mercurial 4.7 (Bug 1485874) r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/01e4a82aa147
hgmo: wrap `csets` field as a `templateutil.mappinglist` r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a772b50b7dd4
hgmo: get context using `scmutil` functions r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/9ebceb9a4da1
hgmo: remove unused variable r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/51c6ff20afac
hgmo: add `automationrelevance` JSON template r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/090cffc7f71c
hgmo: create bugs, reviewers, backouts fields with generators r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/8a320b3c78e7
hgmo: send archives info to template layer in `repoinfo` webcommand r=gps
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7ca5514f709c
hgmo: mark as compatible with Mercurial 4.7 r=gps

Comment 17

[Connor Sheehan [:sheehan]]

Attachment: hgtemplates: add automationrelevance template to `json.patch` (Bug 1485874) r?gps

Overlooked this when making the hgmo extension compatible
with Mercurial 4.7.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/f607eb3657e1
hgtemplates: add automationrelevance template to `json.patch` r=gps