1485999 - The @ebay shortcut doesn't perform the search correctly on locale builds

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect)

Description

[Oana Botisan, Desktop QA]

[Affected versions]:
- Beta 62.0b20
- Nightly 63.0a1

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- macOS 10.13

[Steps to reproduce]:
1. Open Firefox
2. Change browser.search.region to RO in about:config.
3. Close and restart the browser. 
4. Write in the URL bar "@ebay" and press Enter. 

[Expected result]:
- https://www.ebay.com/ is opened.

[Actual result]:
- A search is performed on the default search engine (e.g. google)

[Regression range]:
- last good build: 2018-08-13 
- first bad build: 2018-08-15 

[Additional notes]:
- This issue is reproducing on locale builds, such as RO, FR, DE, IT.

Comment 1

[Ed Lee :Mardak]

I just tested de 62b20 https://ftp.mozilla.org/pub/firefox/releases/62.0b20/mac/de/Firefox%2062.0b20.dmg 

@ebay loads https://www.ebay.de/ for me

Comment 2

[Oana Botisan, Desktop QA]

Attachment: @ebay doesn't perform the search correctly..gif

The first time you open the browser with a profile there is no problem. The problem appears after you restart or close and reopen the browser with the same profile. 
Please look at the screen cast to see the problem reproducing.

Comment 3

[Jenn Chaulk (:jchaulk)]

Hello Oana, can you please see if you can reproduce this on the latest nightly build?  We are still unable to reproduce.

Comment 4

[Oana Botisan, Desktop QA]

Hello,
I can still reproduce the issue on the latest Nightly 63.0a1 (2018-08-28). And now I can't seem to make it work the first time either. 
Even if I change the pref browser.search.region to US it's not working and @ebay is not listed in the Add Search Engine list. 

On the other hand, if I open a profile with the pref browser.search.region already set to US, then @ebay works as expected. And if I change the pref to RO, @ebay still works even after restart. I think the problem is more that the default @search are not updating when the pref is changed.

Comment 5

[Marco Castelluccio [:marco]]

Don't forget the `regression` keyword for regression bugs ;)

Comment 6

[Mike Taylor [:miketaylr]]

Ed, are you able to reproduce with the updated STR in comment #4?

Comment 7

[Mike Taylor [:miketaylr]]

Tim, how important is this regression?

Comment 8

[Ed Lee :Mardak]

The provided "regression" range doesn't include bug 1481559 which was pushed 2018-08-09 10:00 +0000, and this is a new feature, so if it is a bug, it's not a regression.

The STR involves using the internal search aliases directly from the address bar, so it's not activity stream related.

The additional STR in comment 4 changes the region to try to change the search engines, but I believe the feature is intended to only add internal search aliases for some of the default packaged search engines, and that behavior is based on the locale not region.