1486012 - re-implement ICE restart as the creation of new ICE streams on the pre-existing context

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Byron Campen [:bwc]]

In order to make it possible to perform partial ICE restarts, we need to change the way we handle ICE restart. Right now, when an ICE restart happens, we create a whole new ICE context, and then switch over to that new context once ICE succeeds on it. What we should instead be doing is creating extra ICE streams on the context we already have, and then removing the old ones once we're ready.

We probably want to do this before we try to move mtransport into a separate process, because this is a simplification in the mtransport API.

This would mean keying ICE streams based on a combination of transport-id and ufrag/pwd, at least until we use unique ufrag/pwds for each ICE stream.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3229f86d4a4ec8a8e5db50e47cc06a1217904cb1

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=945179b554f11e465f27b6614672585bbe715086

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=862b053c328f5596bf8cd980fdbe8c334bf6a8cc

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d749e5f0de4280ddda350ffa303ef5c2711dd0b5

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30a84394c19f7eceffbb45f81e87d51adaf9b36d

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8685f943b06eb379a4e41b9b34ddfd4790306fb

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc86fd4afc3713d461017ff0da530345b11f54f8

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbe036109268c850baee9e225f20bcc6902b3e5f

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afa3b3ed9cb7ce9e8725bd957315c042953594bc

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=702a7766008ce5b672a2890382480b98d4ab114e

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=397f1b08446400b0e4af1e65fd4371a42622a529

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebdb88a6e8feb37dfd6309290e90f186618edf39

Comment 13

[Byron Campen [:bwc]]

Attachment: Bug 1486012: Rework ICE restart.

Comment 14

[Michael Froman [:mjf]]

Comment on attachment 9009226 [details]
Bug 1486012: Rework ICE restart.

Michael Froman [:mjf] has approved the revision.

Comment 15

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fe28dea27c7d4e9687cb80714edeb188c2736ff

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2da055061b9
Rework ICE restart. r=mjf

Comment 17

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f2da055061b9

Comment 18

[Nils Ohlmeier [:drno]]

This change is breaking interop with Safari and Chrome! 
It looks to me like Firefox is generating new ICE username and password in it's answer, which the other browsers don't seem to like at all (haven't checked the specs yet).

Comment 19

[Nils Ohlmeier [:drno]]

Never mind. It looks like bug 1493146 will fix the problem I'm seeing with Nightly right now. But bug 1493146 hasn't made it into my current Nightly.