Closed
Bug 1486012
Opened 6 years ago
Closed 6 years ago
re-implement ICE restart as the creation of new ICE streams on the pre-existing context
Categories
(Core :: WebRTC: Networking, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In order to make it possible to perform partial ICE restarts, we need to change the way we handle ICE restart. Right now, when an ICE restart happens, we create a whole new ICE context, and then switch over to that new context once ICE succeeds on it. What we should instead be doing is creating extra ICE streams on the context we already have, and then removing the old ones once we're ready. We probably want to do this before we try to move mtransport into a separate process, because this is a simplification in the mtransport API. This would mean keying ICE streams based on a combination of transport-id and ufrag/pwd, at least until we use unique ufrag/pwds for each ICE stream.
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3229f86d4a4ec8a8e5db50e47cc06a1217904cb1
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=945179b554f11e465f27b6614672585bbe715086
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=862b053c328f5596bf8cd980fdbe8c334bf6a8cc
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d749e5f0de4280ddda350ffa303ef5c2711dd0b5
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=30a84394c19f7eceffbb45f81e87d51adaf9b36d
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8685f943b06eb379a4e41b9b34ddfd4790306fb
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc86fd4afc3713d461017ff0da530345b11f54f8
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbe036109268c850baee9e225f20bcc6902b3e5f
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=afa3b3ed9cb7ce9e8725bd957315c042953594bc
Assignee | ||
Comment 10•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=702a7766008ce5b672a2890382480b98d4ab114e
Assignee | ||
Comment 11•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=397f1b08446400b0e4af1e65fd4371a42622a529
Assignee | ||
Comment 12•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebdb88a6e8feb37dfd6309290e90f186618edf39
Assignee | ||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Comment on attachment 9009226 [details] Bug 1486012: Rework ICE restart. Michael Froman [:mjf] has approved the revision.
Attachment #9009226 -
Flags: review+
Assignee | ||
Comment 15•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fe28dea27c7d4e9687cb80714edeb188c2736ff
Comment 16•6 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2da055061b9 Rework ICE restart. r=mjf
Comment 17•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2da055061b9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 18•6 years ago
|
||
This change is breaking interop with Safari and Chrome! It looks to me like Firefox is generating new ICE username and password in it's answer, which the other browsers don't seem to like at all (haven't checked the specs yet).
Flags: needinfo?(docfaraday)
Comment 19•6 years ago
|
||
Never mind. It looks like bug 1493146 will fix the problem I'm seeing with Nightly right now. But bug 1493146 hasn't made it into my current Nightly.
Flags: needinfo?(docfaraday)
You need to log in
before you can comment on or make changes to this bug.
Description
•