Closed Bug 1486192 Opened 3 years ago Closed 3 years ago

Port bug 1446168 to TB: Load tabbox.css as a document stylesheet

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 63.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

tabmail.patch
1.10 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
Bug 1446168 loads now the tabbox.css as document stylesheet. This makes it loading later in the stylesheet chain and this needs us to make to use !important for the margins and paddings in one rule.
Attached patch tabmail.patch — — Splinter Review 
Port of https://hg.mozilla.org/mozilla-central/rev/91dc894ac303#l2.1

With bug 1446168 applied (m-c tip of 25.8.) you see that the selected tab's background color doesn't fill the whole tab. With patch it looks like before.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9003972 - Flags: review?(jorgk)
Comment on attachment 9003972 [details] [diff] [review]
tabmail.patch

Review of attachment 9003972 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't try but I take your word for it.
Attachment #9003972 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/94494bc63014
Port bug 1446168 to TB: Load tabbox.css as a document stylesheet. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
I hope you agree that on comment is better than repeating the same comment three times ;-)
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.