1486313 - Replace makeURI with Services.io.newURI in pageInfo.js

Status: RESOLVED FIXED

(Firefox :: Page Info Window, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

We should replace all occurrences of the deprecated makeURI function with Services.io.newURI here:

https://searchfox.org/mozilla-central/search?q=makeURI&case=false&regexp=false&path=pageInfo.js

The parameters should stay the same.

Comment 1

[Arshad Kazmi [:arshadkazmi42]]

I want to take this up

Comment 2

[Johann Hofmann [:johannh]]

Awesome, let me know if you need any help! Thanks!

Comment 3

[Arshad Kazmi [:arshadkazmi42]]

It needs to be changed only in that file? Or I need to check other files also for this change?

Comment 4

[Arshad Kazmi [:arshadkazmi42]]

Done with the changes.

Added to phabricator and added you as reviewer

https://phabricator.services.mozilla.com/D4389

Comment 5

[Arshad Kazmi [:arshadkazmi42]]

Attachment: Bug 1486313 makeURI replaced with Services.io.newURI

Comment 6

[Arshad Kazmi [:arshadkazmi42]]

Hey Johann,
Any updates on this? I am not sure who is going to do review for this. I have added you as reviewer for this.

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 9004362 [details]
Bug 1486313 makeURI replaced with Services.io.newURI

Johann Hofmann [:johannh] has approved the revision.

Comment 8

[Johann Hofmann [:johannh]]

(In reply to Arshad Kazmi from comment #6)
> Hey Johann,
> Any updates on this? I am not sure who is going to do review for this. I
> have added you as reviewer for this.

Hey Arshad, sorry for the delay, the last days were a bit busy for me.

Thank you for the reminder, that patch looks great!

You now have editbugs access (which means you can edit all bugs), would you like to try it out and set the checkin-needed flag yourself? :)

Thanks!

Comment 9

[Arshad Kazmi [:arshadkazmi42]]

I have added 'checkin flag'

Is this the right way?
Adding '?'

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5deec145c04d
makeURI replaced with Services.io.newURI r=johannh

Comment 11

[Arshad Kazmi [:arshadkazmi42]]

Hey Johann,
I think code is merged now. 
What is the next step for this bug? Do I have to close it? or there is some flag for it?

Comment 12

[Eliza Balazs [:ebalazs_]]

arshadkazmi42, can you please remove the checkin? because this patch is still in the list on checkin-needed bugs. 
Next time you can just add the 'checkin-needed' in the keywords section. Thanks!

Comment 13

[Arshad Kazmi [:arshadkazmi42]]

Hi Eliza,
Updated the flag. I got it now from my other bug flow, that checkin-needed needs to be added in the keywords.

So can I add checkin-needed keyword in this bug now? Or its already checkedin?

Comment 14

[Eliza Balazs [:ebalazs_]]

This patch is already landed. Please see Comment 10.

Comment 15

[Arshad Kazmi [:arshadkazmi42]]

Oh. yes. missed that comment. 
So what is the next step? This bug needs to be closed?
Do I have to close the bug? Or there is someone else who handles this?

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5deec145c04d

Comment 17

[Eliza Balazs [:ebalazs_]]

No need to take any other action, as you can see in the previous comment your patch was merged in mozilla-central and it was closed as Resolved fixed.

Comment 18

[Arshad Kazmi [:arshadkazmi42]]

Ok. thank your for the details :)