Closed Bug 1486374 Opened 2 years ago Closed 2 years ago

DAMP profiles records only the second half of the test run

Categories

(Testing :: Talos, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MOZ_PROFILER_STARTUP_ENTRIES is probably too low for DAMP.
The profiler must have increased its usage of entries...

It is currently set to one million, I'll try with 2 millions.
https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#431

I let the perf-html team know about the increased usage of entries.
It looks like 2 millions is enough. It makes perf-html really slow to load and navigate, but at least we can see all tests!
It may be useful to run DAMP against just one or a set of subtests from try. We can do that locally via `--subtest`, but that's not something we can pass to try.

https://perfht.ml/2MORkx1
Comment on attachment 9004159 [details]
Bug 1486374 - Increase profiler buffer entries to cover one full DAMP run. r=jmaher

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.
Attachment #9004159 - Flags: review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c2e6069684
Increase profiler buffer entries to cover one full DAMP run. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/58c2e6069684
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.