1486374 - DAMP profiles records only the second half of the test run

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Alexandre Poirot [:ochameau]]

MOZ_PROFILER_STARTUP_ENTRIES is probably too low for DAMP.
The profiler must have increased its usage of entries...

It is currently set to one million, I'll try with 2 millions.
https://searchfox.org/mozilla-central/source/testing/talos/talos/test.py#431

I let the perf-html team know about the increased usage of entries.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5c999915577e261e811a72d62ba34d78dba2e10

Comment 2

[Alexandre Poirot [:ochameau]]

It looks like 2 millions is enough. It makes perf-html really slow to load and navigate, but at least we can see all tests!
It may be useful to run DAMP against just one or a set of subtests from try. We can do that locally via `--subtest`, but that's not something we can pass to try.

https://perfht.ml/2MORkx1

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1486374 - Increase profiler buffer entries to cover one full DAMP run. r=jmaher

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9004159 [details]
Bug 1486374 - Increase profiler buffer entries to cover one full DAMP run. r=jmaher

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c2e6069684
Increase profiler buffer entries to cover one full DAMP run. r=jmaher

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/58c2e6069684