[meta] Fix and improve devtools performance regression CI (aka DAMP)

NEW
Unassigned

Status

defect
P3
normal
2 years ago
3 months ago

People

(Reporter: ochameau, Unassigned)

Tracking

(Depends on 19 bugs, Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

Over the last year, I kept working on various performance improvements and I've seen performance regress as I fixed things.
It became pretty clear that DAMP, in its current state, miss many and significant regressions.

A good example was bug 1359855. In order to prevent loading DevTools codebase at Firefox startup, it has been delayed to the first time we interact with the tools.
The piece of code that has been moved is significant.
So significant that sessionrestore talos test reported a win for firefox startup when we moved it to later.
But DAMP should have been reporting the same amount as a regression for when we open the first tool. But it did not.

This precise scenario is most likely related to bug 1394804.

But that one bug can't explain everything.

The fact that DAMP only tracks the summary value is another significant issue (bug 1397745).

Also, we have to review each panel test to ensure each OPEN/RELOAD/CLOSE steps are correctly tracked and that there is no pending computation that overlap between each test. (like bug 1396539, specific to the inspector).

I imagine there is some other improvements to be made to DAMP. Let's use this bug as a meta bug for improving DAMP.
Depends on: 1398068
Priority: -- → P3
Depends on: 1399779
Depends on: 1401207
Depends on: 1401187
Depends on: 1401901
Depends on: 1399465
Depends on: 1407826
Depends on: 1408354
Depends on: 1408355
Depends on: 1409322
Depends on: 1409328
Depends on: 1154874
Depends on: 1358180
Depends on: 1415472
Depends on: 1415532
Depends on: 1419326
Depends on: 1419327
Depends on: 1419328
Depends on: 1414286
Depends on: 1419411
Depends on: 1419413
Depends on: 1419414
Depends on: 1419415
Depends on: 1420233
Depends on: 1420303
Depends on: 1421334
Depends on: 1422052
Depends on: 1426206
Depends on: 1426674
Depends on: 1426688
Depends on: 1432416
Depends on: 1434849
Depends on: 1436022
Depends on: 1439369
Depends on: 1439534
Depends on: 1444826
Depends on: 1449919
Depends on: 1441703
Depends on: 1454580
Depends on: 1454582
Depends on: 1462564
Depends on: 1466479
Product: Firefox → DevTools
Depends on: 1473322
Depends on: 1486374
Depends on: 1515108
Depends on: 1539195
Depends on: 1551519
You need to log in before you can comment on or make changes to this bug.