1486487 - <label control> for a <checkbox> only focuses the control instead of checking it

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement, P3)

Description

[(no longer active)]

See this code: https://searchfox.org/mozilla-central/rev/e126996d9b0a3d7653de205898517f4f5b632e7f/toolkit/content/widgets/text.xml#285

This makes the following code snippet not behave as expected:

  <label for="checkbox"/>
  <checkbox id="checkbox"/>

since clicking on the label only focuses the checkbox, and we don't even draw the focus rect by default, so it seems like nothing happens when clicking on the label.  It is much better to try to detect the type of the control here and check the checkbox if the type of the control is indeed a checkbox.

Comment 2

[(no longer active)]

Attachment: Toggle a label's control in case it's a checkbox

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9005517 [details] [diff] [review]
Toggle a label's control in case it's a checkbox

>       <handler event="click" action="if (this.disabled) return;
>                                      var controlElement = this.labeledControlElement;
>-                                     if(controlElement)
>+                                     if(controlElement) {
>                                        controlElement.focus();
>+                                       if (controlElement.localName === 'checkbox' &amp;&amp;
>+                                           controlElement.namespaceURI === 'http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul') {
>+                                         controlElement.checked = !controlElement.checked;
>+                                       }
>+                                     }
>                                     "/>

Please stop using the action attribute for this as it's getting overly long:

      <handler event="click"><![CDATA[
         // code goes here
      ]]></handler>

Comment 4

[(no longer active)]

Attachment: Bug 1486487 - Toggle a label's control in case it's a checkbox; r=dao

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9005930 [details]
Bug 1486487 - Toggle a label's control in case it's a checkbox; r=dao

Dão Gottwald [::dao] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb51f1914eb
Toggle a label's control in case it's a checkbox; r=dao

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dbb51f1914eb