1487453 - Content blocking checkboxes can't be toggled by clicking their label

Status: RESOLVED DUPLICATE of bug 1487048

(Firefox :: Settings UI, defect, P1)

Description

[Dão Gottwald [:dao]]

Clicking a checkbox's label is supposed to toggle the checkbox.

Comment 1

[Johann Hofmann [:johannh]]

Ah, I was about to block this on bug 1486487, but I now realize that XUL checkboxes have a src attribute which we could use in this case.

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/checkbox.src

I agree that we might want to use that to fix this. That would probably also fix bug 1487455...

Comment 2

[Johann Hofmann [:johannh]]

Not sure why that resolved it...

Comment 3

[(no longer active)]

I have a patch for this in bug 1486487.

Comment 4

[Dão Gottwald [:dao]]

I suspect bug 1486487 would only partially fix this. Presumably it wouldn't take care of the hover feedback that indicates that clicking the label would toggle the checkbox.

Comment 5

[(no longer active)]

It won't add any hover effects, that's right.

Comment 6

[:Gijs (he/him)]

Ehsan, are you intending to fix this after fixing bug 1486487?

(Tracking as this would be a regression in a feature shipping with 63)

Comment 7

[(no longer active)]

No, I believe this is a dupe of bug 1487048 and will be fixed by the patch attached there.  Not marking a dupe to give Dao a chance to agree or disagree.

(I do not plan to submit a patch here for now.)