display: list-item should be supported on legend, but not on fieldset

RESOLVED FIXED in Firefox 64

Status

()

defect
P3
normal
RESOLVED FIXED
8 months ago
5 months ago

People

(Reporter: zcorpan, Assigned: TYLin)

Tracking

(Blocks 1 bug, {dev-doc-needed})

Trunk
mozilla64
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox63 wontfix, firefox64 fixed)

Details

Attachments

(5 attachments)

(Reporter)

Updated

8 months ago
Blocks: fieldset
Priority: -- → P3
Component: Layout → Layout: Generated Content, Lists, and Counters
The github issue seems to be leaning towards supporting it after all.
Which means we need to make list numbering work for fieldset/legend.
(Reporter)

Comment 2

8 months ago
Yes, for legend, but not for fieldset.
(Assignee)

Comment 3

7 months ago
Those arguments were added in bug 591737 to create a triangle for the
summary frame, but <summary> has been re-implemented by using "list-item"
since then. Now the only caller is nsBlockFrame itself, so there's no need
to expose those arguments.
(Assignee)

Comment 4

7 months ago
The function was renamed in bug 1171419 Part 10.

Depends on D6839
(Assignee)

Comment 5

7 months ago
nsCSSFrameConstructor::FindDisplayData() guarantees a block with "display:
list-item" will be constructed by ConstructBlock() (either through
ConstructScrollableBlock() or ConstructNonScrollableBlock()).

This is also a preparation to fix bug 1491915 since we want to control
bullet frame creation under column hierarchy.

Depends on D6840
(Assignee)

Comment 8

7 months ago
I found this bug while doing the necessary refactoring for bug 1491915. I'll take a stab on this bug.
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Summary: display: list-item should not be supported on fieldset or legend → display: list-item should be supported on legend, but not on fieldset
(Assignee)

Updated

7 months ago
See Also: → 1491915
Comment on attachment 9011933 [details]
Bug 1486602 Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem()

Mats Palmgren (:mats) has approved the revision.
Attachment #9011933 - Flags: review+
Comment on attachment 9011934 [details]
Bug 1486602 Part 2 - Replace RenumberLists with RenumberList in comments

Mats Palmgren (:mats) has approved the revision.
Attachment #9011934 - Flags: review+
Comment on attachment 9011936 [details]
Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend

Mats Palmgren (:mats) has approved the revision.
Attachment #9011936 - Flags: review+
Comment on attachment 9011937 [details]
Bug 1486602 Part 5 - Add a wpt test for legend list-item numbering, and update test expectations

Mats Palmgren (:mats) has approved the revision.
Attachment #9011937 - Flags: review+
Attachment #9011936 - Attachment description: Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: item-list" on legend → Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend
Attachment #9011937 - Attachment description: Bug 1486602 Part 5 - Update test expectations → Bug 1486602 Part 5 - Add a wpt test for legend list-item numbering, and update test expectations
Comment on attachment 9011935 [details]
Bug 1486602 Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild()

Mats Palmgren (:mats) has approved the revision.
Attachment #9011935 - Flags: review+

Comment 14

7 months ago
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6674c998a39
Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem() r=mats
https://hg.mozilla.org/integration/autoland/rev/0923a919f70a
Part 2 - Replace RenumberLists with RenumberList in comments r=mats
https://hg.mozilla.org/integration/autoland/rev/8f4f56568e67
Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild() r=mats
https://hg.mozilla.org/integration/autoland/rev/99738159fdff
Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend r=mats
https://hg.mozilla.org/integration/autoland/rev/3856cee32a29
Part 5 - Add a wpt test for legend list-item numbering, and update test expectations r=mats
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13233 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13233
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Xb1ZDe9WR2Kd1P4fNRhJnw)
Flags: in-testsuite+
QA Contact: svoisen
QA Contact: svoisen
Note to docs team:

I've added a note to the Fx 64 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#CSS

I think Rachel Andrew did some updates on the compat data for this; that's probably all that's needed for the docs work, but it needs checking.
You need to log in before you can comment on or make changes to this bug.