1486602 - display: list-item should be supported on legend, but not on fieldset

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)

Description

[Simon Pieters [:zcorpan]]

See
https://github.com/whatwg/html/issues/3955
https://github.com/whatwg/html/pull/3934
https://github.com/web-platform-tests/wpt/pull/12640

Comment 1

[Mats Palmgren (inactive)]

The github issue seems to be leaning towards supporting it after all.
Which means we need to make list numbering work for fieldset/legend.

Comment 2

[Simon Pieters [:zcorpan]]

Yes, for legend, but not for fieldset.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1486602 Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem()

Those arguments were added in bug 591737 to create a triangle for the
summary frame, but <summary> has been re-implemented by using "list-item"
since then. Now the only caller is nsBlockFrame itself, so there's no need
to expose those arguments.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1486602 Part 2 - Replace RenumberLists with RenumberList in comments

The function was renamed in bug 1171419 Part 10.

Depends on D6839

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1486602 Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild()

nsCSSFrameConstructor::FindDisplayData() guarantees a block with "display:
list-item" will be constructed by ConstructBlock() (either through
ConstructScrollableBlock() or ConstructNonScrollableBlock()).

This is also a preparation to fix bug 1491915 since we want to control
bullet frame creation under column hierarchy.

Depends on D6840

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend

Depends on D6841

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1486602 Part 5 - Add a wpt test for legend list-item numbering, and update test expectations

Depends on D6842

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I found this bug while doing the necessary refactoring for bug 1491915. I'll take a stab on this bug.

Comment 9

[Mats Palmgren (inactive)]

Comment on attachment 9011933 [details]
Bug 1486602 Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem()

Mats Palmgren (:mats) has approved the revision.

Comment 10

[Mats Palmgren (inactive)]

Comment on attachment 9011934 [details]
Bug 1486602 Part 2 - Replace RenumberLists with RenumberList in comments

Mats Palmgren (:mats) has approved the revision.

Comment 11

[Mats Palmgren (inactive)]

Comment on attachment 9011936 [details]
Bug 1486602 Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend

Mats Palmgren (:mats) has approved the revision.

Comment 12

[Mats Palmgren (inactive)]

Comment on attachment 9011937 [details]
Bug 1486602 Part 5 - Add a wpt test for legend list-item numbering, and update test expectations

Mats Palmgren (:mats) has approved the revision.

Comment 13

[Mats Palmgren (inactive)]

Comment on attachment 9011935 [details]
Bug 1486602 Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild()

Mats Palmgren (:mats) has approved the revision.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6674c998a39
Part 1 - Remove arguments of nsBlockFrame::CreateBulletFrameForListItem() r=mats
https://hg.mozilla.org/integration/autoland/rev/0923a919f70a
Part 2 - Replace RenumberLists with RenumberList in comments r=mats
https://hg.mozilla.org/integration/autoland/rev/8f4f56568e67
Part 3 - Create bullet frame for block frames in nsCSSFrameConstructor::ConstructBlock() instead of in their SetInitialSingleChild() r=mats
https://hg.mozilla.org/integration/autoland/rev/99738159fdff
Part 4 - Introduce FCDATA_MAY_NEED_BULLET to support "display: list-item" on legend r=mats
https://hg.mozilla.org/integration/autoland/rev/3856cee32a29
Part 5 - Add a wpt test for legend list-item numbering, and update test expectations r=mats

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13233 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 17

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/c6674c998a39
https://hg.mozilla.org/mozilla-central/rev/0923a919f70a
https://hg.mozilla.org/mozilla-central/rev/8f4f56568e67
https://hg.mozilla.org/mozilla-central/rev/99738159fdff
https://hg.mozilla.org/mozilla-central/rev/3856cee32a29

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13233
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/Xb1ZDe9WR2Kd1P4fNRhJnw)

Comment 20

[Chris Mills [:cmills]]

Note to docs team:

I've added a note to the Fx 64 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#CSS

I think Rachel Andrew did some updates on the compat data for this; that's probably all that's needed for the docs work, but it needs checking.