1491915 - Fix the rendering of bullet list after enabling "layout.css.column-span.enabled"

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The implementation in bug 1421105 doesn't render bullet list correctly.

Step to reproduce:
Enable "layout.css.column-span.enabled" and load layout/reftests/bugs/571281-1b.html. 

Expected result:
One bullet for the <li> element.

Actual result:
Two bullet for the <li> element.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Patches in Bug 1486602 have necessary refactoring for this bug.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1491915 - Fix bullet frame creation for columns.

The modification to nsLayoutUtils::GetFirstLinePosition() is needed because
we need to get the correct first line position when there's an outside
bullet on ColumnSetWrapperFrame.

The difference between the two newly added tests is "overflow: hidden" on
the columns.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c21bf3a5e752
Fix bullet frame creation for columns. r=bzbarsky

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14113 for changes under testing/web-platform/tests

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c21bf3a5e752

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged