1486605 - [checks] Add errors and warnings filters

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

We need two new Translation status filters (Errors and Warnings) which should return "Active translations with Errors/Warnings".

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1075

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/8a9041f0b5a5dab0f80859a9fc58a39149187096
Fix bug 1486605: Add errors and warnings filters (#1075)


* Use pluralized forms for error and warning statuses on frontend

To be consistent with the UI and URL parameters.

* Use errors and warnings statuses only for strings in VCS

In practice that means approved and fuzzy strings only, instead of all
active strings (which also include unreviewed suggestions).

That's because only strings in VCS require special attention, i.e.
presentation on dashboards and the ability to be filtered, because they
could be breaking the product.

Errors and warnings in unreviewed suggestions are not only displayed
on dashboards and filterable (as unreviewed suggestions), but will also
show up if somebody tried to approve them (as failed quality checks).

That change also means error/warning numbers in Pontoon dashboards
should match those numbers on Elmo and web dashboards.

And yes, it also means that it's nice that we implemented Translation.active,
but we don't need it for checks.

* Temporarily hide filters from the menu until bug 1485611 is fixed