Closed Bug 1486845 Opened 3 years ago Closed 3 years ago

Remove unused eventNode handling in tabbox

Categories

(Toolkit :: XUL Widgets, enhancement)

Product:
Toolkit
Component:
XUL Widgets
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: bgrins, Assigned: dao)

References

Details

Attachments

(1 file)

patch
3.57 KB, patch
enndeakin
: review+
Details | Diff | Splinter Review 
From https://phabricator.services.mozilla.com/D3989:

It's not clear to me that the eventNode setter is ever run (we aren't using it here but rather setting _eventNode directly), and if we were to start using it here I think the setter would throw as-written since it unconditionally calls Services.els.removeSystemEventListener(this._eventNode,....

I think we can actually remove a bunch of this code - I think the only case we ever use is eventnode="document" and I don't think we ever dynamically change eventNode from JS.
Component: Tabbed Browser → XUL Widgets
Product: Firefox → Toolkit
comm-central also only ever uses eventnode="document":

https://dxr.mozilla.org/comm-central/search?q=eventnode%3D&redirect=false

and doesn't use the eventNode property:

https://dxr.mozilla.org/comm-central/search?q=.eventNode&redirect=false
Attached patch patch — — Splinter Review
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #9004814 - Flags: review?(enndeakin)
Attachment #9004814 - Flags: review?(enndeakin) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef8c5c529210
Remove unused eventNode handling in tabbox. r=enn
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6abe84479a9e
Remove unused eventNode handling in tabbox. r=enndeakin
Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.
https://hg.mozilla.org/mozilla-central/rev/6abe84479a9e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.