1487042 - Remove NS_STYLE_IMAGELAYER_SIZE macro definitions.

Status: RESOLVED DUPLICATE of bug 1504618

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Ian Gralinski]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180807170231

Steps to reproduce:

Nothing to reproduce - this is a patch for bug 1277133


Actual results:

Currently using NS_STYLE_IMAGELAYER_SIZE* macro definitions


Expected results:

Want to change this to enum class StyleImageLayerSize::*

Comment 1

[Ian Gralinski]

Attachment: bug1487042.patch

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9004829 [details] [diff] [review]
bug1487042.patch

Review of attachment 9004829 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsStyleConsts.h
@@ +322,5 @@
>  };
>  
>  // See nsStyleImageLayers
> +enum class StyleImageLayerSize : uint8_t {
> +  Contain,

These look unused, let's remove them instead?

Comment 3

[Ian Gralinski]

Attachment: Removed NS_STYLE_IMAGELAYER_SIZE macro definitions since they are unused

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9004834 [details] [diff] [review]
Removed NS_STYLE_IMAGELAYER_SIZE macro definitions since they are unused

Review of attachment 9004834 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsStyleConsts.h
@@ -321,5 @@
>    Round
>  };
>  
> -// See nsStyleImageLayers
> -enum class StyleImageLayerSize : uint8_t {

This looks good, but you need to merge the two patches. This patch alone doesn't apply on top of the repo.

Also, you need to request review to someone. Feel free to ping me on #introduction if you need help with that.

Thanks!

Comment 5

[Cameron McCormack (:heycam)]

Hi Ian, I think the next step is to attach a merged version of the old and new patch, and request review from Emilio.  Please let us know if there's anything blocking you, thanks!

Comment 6

[singuliere]

There no longer is any occurrence of NS_STYLE_IMAGELAYER_SIZE according to searchfox. Maybe this bug can be closed?

Comment 7

[singuliere]

It appears this bug is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1504618

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Agreed.