Closed Bug 1487218 Opened Last year Closed Last year

Update the Preferences UI for the case where an extension is controlling TP

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel-64])

Attachments

(6 files)

We can probably improve the current UI...
Assignee: nobody → ehsan
I suspect given how recently this was filed, and how recently ehsan assigned himself, that this is being actively worked on. So I'm setting this to P1 for now.
Priority: -- → P1
Might not make 63, and I think that's acceptable.
Whiteboard: [privacy-panel-64]
Status: NEW → ASSIGNED
Attached image UX mock
Bryan also asked me to see if I can apply the same visual styling to other places where the similar notices appear in the Preferences UI.
Comment on attachment 9005700 [details]
Bug 1487218 - Part 1: Update the Preferences UI for the case where an extension is controlling tracking protection when Content Blocking is enabled; r=johannh

Johann Hofmann [:johannh] has approved the revision.
Attachment #9005700 - Flags: review+
Comment on attachment 9005701 [details]
Bug 1487218 - Part 2: Use the new extension controlled styling for other parts of the Preferences UI; r=johannh

Johann Hofmann [:johannh] has approved the revision.
Attachment #9005701 - Flags: review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c448cf1ddaf
Part 1: Update the Preferences UI for the case where an extension is controlling tracking protection when Content Blocking is enabled; r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/5256fea67af2
Part 2: Use the new extension controlled styling for other parts of the Preferences UI; r=johannh
https://hg.mozilla.org/mozilla-central/rev/3c448cf1ddaf
https://hg.mozilla.org/mozilla-central/rev/5256fea67af2
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
There are generic styles for message bars. I filed bug 1491003 to use them for extension controlled messages.
I reproduced this issue using Fx 63.0a1 (2018-08-29)on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 63.0b11 on Windows 10 x64, macOS 10.13.6 and Ubuntu 14.04 LTS.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.