14874 - [Feature] Each edit control needs a context menu

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Jan Carpenter]

Overview Description:
Can't bring up a right click menu in the location bar

Steps to Reproduce:
- put mouse cursor in location bar and right click


Actual Results:
nothing happens

Expected Results:
I expect to see the edit menu come up (undo, cut, copy, paste, etc.)

Build Date & Platform Bug Found:
1999092112 Win98
I've seen this for a while, but thought it was reported.

Comment 1

[troy]

I think the location bar is Ender, so I guess this would be an editor bug?

Comment 2

[buster]

context menus are not yet implemented.  When they are, it'll be the browser that
brings up the context menu in conjunction with the editor.  Assigned to simon.

Comment 3

[Simon Fraser [no longer active]]

I think the XPApps team would hook up this context menu.

Comment 4

[Michael Lowe]

On Netscape 4.x under Windows, all edit controls have a [Undo | Cut Copy Paste
Delete | Select All ] menu.   This includes edit controls in the chrome and edit
controls in html forms.

Comment 5

[Michael Lowe]

Are you sure that the browser should be handling this?   On Window OS all edit
control automatically have a context menu built into it, it does not need to be
implemented by the application.

Comment 6

[buster]

I think it's a browser bug.  The editor APP will bring up a context menu in the
editor window.  But the core editor itself doesn't know anything
about UI widgets like context menus.  So the browser will have to somehow be a
mouse listener on the text control and intercept the right mouse
click to bring up a context menu.  Probably the browser will capture ALL right
clicks in the content area.

Having said all that, it's entirely reasonable for the editor team to provide
some sort of xul menu description for a basic editing context menu.  I envision
this as a fragment, meant to be merged in with whatever other menu items the
application wants on the context menu.  That part could be done by
charley, simon, or kathy.  Whoever is looking into context menus in general
for the editor team should work on that part, then assign the bug to browser
(and probably submit another one against mail for text controls in mail compose
window, address book, etc.)

Comment 7

[rubydoo123]

cahnging to M14 -- post dogfood

Comment 8

[rubydoo123]

assigning to Simon and setting to past beta

Comment 9

[Jan Carpenter]

*** Bug 17423 has been marked as a duplicate of this bug. ***

Comment 10

[sairuh (rarely reading bugmail)]

spam: could affect my area, so adding self to cc list.

Comment 11

[Simon Fraser [no longer active]]

*** Bug 23696 has been marked as a duplicate of this bug. ***

Comment 12

[Dan Erikson]

*** Bug 25578 has been marked as a duplicate of this bug. ***

Comment 13

[Dan Erikson]

*** Bug 25578 has been marked as a duplicate of this bug. ***

Comment 14

[Simon Fraser [no longer active]]

M20

Comment 15

[Phil Peterson]

Oh, man, that's a complete bummer. I use context menus in edit controls all the
time.

Comment 16

[Simon Fraser [no longer active]]

Having talked to hyatt, I should be able to fix this for HTML text inputs. XUL 
inputs are harder. I filed bug 33675 on that case. I'll try doing HTML text input 
context menus for M15.

Comment 17

[sairuh (rarely reading bugmail)]

adding akkana, since her fix to bug 27827 might come into conflict with this 
issue.

Comment 18

[Simon Fraser [no longer active]]

M16 this puppy

Comment 19

[Dan203]

Shouldn't the context menus for controls be handled in XBL? That way the all 
controls would maintain a consistant behavior even when modifications to the XBL 
are made. This would also prevent every apps team from having to impliment the 
context menues for controlls themselves. A hack could be accomplished simply by 
using the new XBL methods Hyatt checked in last week, and listining for the 
mouseup handler. Then you could check to see if the right mouse button was 
pressed (not sure how this would effect Mac) and if it was then use JS to show a 
menu (imported from a global XUL file) and call event.preventDefault() to 
prevent further processing of the event. Now I know this is not the most elegant 
solution but it should work as long as my inderstanding of Hyatt's check in is 
correct!

Comment 20

[Simon Fraser [no longer active]]

*** Bug 27375 has been marked as a duplicate of this bug. ***

Comment 21

[Simon Fraser [no longer active]]

Reassign to brade

Comment 22

[leger]

Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.

Comment 23

[rubydoo123]

this cannot be resolved until 37950 is resolved, and that bug has a date set at 
6/1 -- the date for 14874 needs to be past that date.

Comment 24

[leger]

Moving to [6/01]

Comment 25

[Kathleen :Brade]

hoping to work on this bug soon

Comment 26

[leger]

Changing from [6/01] to [6/15]

Comment 27

[Kathleen :Brade]

Context Menus now work on edit fields in the browser window.  There were a few 
problems with detecting that we were in an edit field which I have fixed with my 
checkin.  Known issues related to this bug are that commands may not execute due 
to a switch of focus when clicking and debug builds will have 2 asserts before 
the context menu is rendered.  These issues are filed as separate bugs (at last 
the first one is) and are unrelated to this fix.

Short Summary:  I believe this fix is checked in but it is currently blocked by 
several other bugs.

Comment 28

[Chris Petersen]

Can't verify since brade indicates it's blocked by other bugs. I will need to be 
notified when these remaining issues are fixed.

Comment 29

[Chris Petersen]

Based on the steps included, I'm not able to get a contextual menu to appear when 
focus is in the location bar. Tested on The June 23 build (2000062308) on Mac OS 
9 and Windows 98. If I'm missing a step to verify, let me know.

Comment 30

[Blake Ross]

Chris: the url bar problem has been split off into bug 43936

Comment 31

[Chris Petersen]

Based on Kathy's comments, this has been fixed in the June 30th builds.