Closed
Bug 1487402
Opened 6 years ago
Closed 6 years ago
Selection should stop notifying AutoCopyListener of selection changes after unlinked
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox61 | --- | unaffected |
| firefox62 | --- | unaffected |
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(1 file)
This is a regression of bug 1486370. Unlink of Selection removes all nsISelectionListener first, then, it removes all its ranges since it does not want to notify the changes anymore. After bug 1486370, Selection starts to store only bool flag whether it should notify AutoCopyListener of selection changes. So, unless it sets the bool flag to false in Unlink, it'll notify selection change caused by Unlink.
|
Assignee | |
Updated•6 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b2929cbf28da37ac5668c0b9b4b8cedf000a86b
|
|
Assignee | |
Comment 2•6 years ago
|
||
This is a regression of bug 1486370. Unlink of Selection removes all nsISelectionListener first, then, it removes all its ranges since it does not want to notify the changes anymore. After bug 1486370, Selection starts to store only bool flag whether it should notify AutoCopyListener of selection changes. So, unless it sets the bool flag to false in Unlink, it'll notify selection change caused by Unlink.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9005246 [details] Bug 1487402 - Selection should stop notifying AutoCopyListener of selection changes after unlinked Olli Pettay [:smaug] has approved the revision.
Attachment #9005246 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/2fe5a97dd750 Selection should stop notifying AutoCopyListener of selection changes after unlinked r=smaug
|
|
Assignee | |
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0da3ab8d7ef384c9c7be75191e6745776e1e0a7f
|
||
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2fe5a97dd750
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•