1487493 - Enable pref for CSS Containment (layout.css.contain.enabled)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Daniel Holbert [:dholbert]]

Filing this bug on turning on CSS Containment pref when it's ready.

(i.e. setting layout.css.contain.enabled = true)

(For now I'm assuming we'll let it ride the trains once we pref it on.  But if we want to give it a separate nightly-only bake time & enable it for release versions later on, we can file a separate bug for that second part down the line.)

Comment 1

[Sebastian Zartner [:sebo]]

In any case, this need to be documented on https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#contain-property.

When it ships, the support info on https://developer.mozilla.org/en-US/docs/Web/CSS/contain needs to be updated.

Sebastian

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Is it still the plan to ship this in 69 as mentioned in Intent to ship?

Comment 3

[Daniel Holbert [:dholbert]]

I think so. As far as I'm aware, bug 1476127 and bug 1555757 are the only bugs that block shipping at this point.

In the next week or two, I plan to post patches for those and then a patch here to remove the EARLY_BETA_OR_EARLIER restriction.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1487493: Remove early-beta restriction on CSS Containment (i.e. let it ride the trains to release). r=TYLin

Comment 5

[Daniel Holbert [:dholbert]]

Once this lands on Nightly, I'll request uplift to merge it to Beta [version 69 as of today-ish, since this is merge week]. Should be a safe/trivial uplift, since it's just removing a guard that would only take effect later in the beta cycle anyway.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58154cdbf898
Remove early-beta restriction on CSS Containment (i.e. let it ride the trains to release). r=TYLin

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 9076614 [details]
Bug 1487493: Remove early-beta restriction on CSS Containment (i.e. let it ride the trains to release). r=TYLin

Beta/Release Uplift Approval Request

• User impact if declined: CSS Containment feature won't be enabled yet. (Which means sites that use it may not have the correct layout, and some new CSS Containment optimizations won't be applied.)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feature is already preffed on through early-beta, and this patch is simply removing the early-beta restriction so that it can proceed past that and be released as part of Firefox 69, since we've fixed all known blocker-level bugs in the feature.
• String changes made/needed: None

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58154cdbf898

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9076614 [details]
Bug 1487493: Remove early-beta restriction on CSS Containment (i.e. let it ride the trains to release). r=TYLin

Removes the early Beta guard on CSS Containment so it can ride the 69 train as called out in the Intent to Ship. Approved for 69.0b4.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6dae45b2816

Comment 12

[j.j.]

(In reply to Sebastian Zartner [:sebo] from comment #1)

In any case, this need to be documented on
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#contain-property

I changed this from "This feature is shipping in Firefox 70" to Firefox 69

Comment 13

[Sebastian Zartner [:sebo]]

I have added it to the release notes for Firefox 69 and created a PR to update the browser compatibility info.

Sebastian

Comment 14

[Chris Mills [:cmills]]

(In reply to Sebastian Zartner [:sebo] from comment #13)

I have added it to the release notes for Firefox 69 and created a PR to update the browser compatibility info.

Sebastian

Thanks for doing this Sebastian!

Rachel just updated the property page with an example, and added a landing page for containment:

• https://developer.mozilla.org/en-US/docs/Web/CSS/contain
• https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Containment

Can we get a review of these please dholbert? Best place to write review comments is probably https://github.com/mdn/sprints/issues/2106

Comment 15

[Daniel Holbert [:dholbert]]

I've just posted some nits on the MDN content to Chris and Rachel in slack. (I didn't notice the github link until I'd finished posting all of my feedback comments in slack, sorry) :)

Thanks for the docwriting!