Closed Bug 1532471 Opened 8 months ago Closed 7 months ago

Let CSS Containment ride the trains to early beta


(Core :: CSS Parsing and Computation, defect, P3)




Tracking Status
firefox67 --- wontfix
firefox68 --- fixed


(Reporter: dholbert, Assigned: dholbert)



(Keywords: dev-doc-needed)


(2 files)

Once we've landed bug 1530896 (turning off contain:style for now), I think we'll be in a good enough position to enable CSS Containment for Nightly testing.

There are a few remaining bugs (blocking bug 1463594 and bug 1463593) to be addressed before we allow it to fully ride the trains, but I don't think they should block nightly testing, and I expect that by the end of Nightly 68, we'll have fixed enough of them to have it usable for Early Beta too.

So: I propose that at the start of the Nightly 68 cycle (in ~2 weeks), we pref on CSS Containment on mozilla-central (with a guard to let it ride trains up to early beta).

(And if all goes well & we fix the bugs during the nightly 68 cycle, then we can remove the "early beta" guard in bug 1487493 to let it ride the trains all the way.)

I'm aiming to land a patch to do this pref-flip after the merge, BTW (i.e. next week).

I'll post a patch for review soon, but won't land it until Nightly becomes version 68.

Flags: needinfo?(dholbert)

Thanks for the review. Leaving ni=me to remind myself to land this early next week, and to post an intent-to-ship.

Try run:

(There are two unrelated crashtest oranges, and a bunch of other green crashtest runs.)

Intent-to-ship thread:!topic/

I posted answers to our intent-to-implement questions as well, because our original intent-to-implement thread predated our current boilerplate:

I triggered lando, so landing is queued for this (will land automatically after the tree reopens).

Flags: needinfo?(dholbert)
Pushed by
part 1: Define CSS containment about:config pref in StaticPrefList.h rather than in all.js. r=emilio
Pushed by
part 2: Enable CSS containment for early beta and earlier. r=emilio
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Backed out changeset b19a49c2a419 (bug 1532471) for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js

  • just part 2 was backed out


Failure push:

Failure log:

[task 2019-03-19T10:05:41.891Z] 10:05:41 INFO - TEST-START | devtools/shared/tests/unit/test_css-properties-db.js
[task 2019-03-19T10:05:43.165Z] 10:05:43 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | xpcshell return code: 0
[task 2019-03-19T10:05:43.167Z] 10:05:43 INFO - TEST-INFO took 1276ms
[task 2019-03-19T10:05:43.169Z] 10:05:43 INFO - >>>>>>>
[task 2019-03-19T10:05:43.170Z] 10:05:43 INFO - PID 8287 | [8287, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2528
[task 2019-03-19T10:05:43.172Z] 10:05:43 INFO - PID 8287 | JavaScript strict warning: resource://devtools/shared/Loader.jsm, line 220: ReferenceError: reference to undefined property "name"
[task 2019-03-19T10:05:43.175Z] 10:05:43 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)

Flags: needinfo?(dholbert)
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---

Yeah, it looks like I have to run "./mach devtools-css-db" to update our in-tree devtools CSS property database.

Attachment #9050729 - Attachment description: Bug 1532471 part 2: Enable CSS containment for early beta and earlier. r?emilio → Bug 1532471 part 2: Enable CSS containment for early beta and earlier. r=emilio
Pushed by
part 2: Enable CSS containment for early beta and earlier. r=emilio
Flags: needinfo?(dholbert)
Closed: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.