Closed
Bug 1487500
Opened 3 years ago
Closed 3 years ago
Make the 'create-interactive' action safer
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(firefox-esr60 fixed, firefox62 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(2 files)
I started writing a new version of this in bug 1487444, and was a little more circumspect about whitelisting scopes. I'm not sure there's much else to change, but it warrants more thinking-about.
Assignee | ||
Comment 1•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92873bcb8fbe04771426673e2f611690950d3cae
Assignee | ||
Comment 2•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d16b6d3a75adcca9d85bb8b603bf111dacaa275
Assignee | ||
Comment 3•3 years ago
|
||
Some whitelisting of scopes, and some notes on security of the operation.
Assignee | ||
Comment 4•3 years ago
|
||
..and use this to allow create-interactive on level 3, but only for testers.
Assignee | ||
Comment 5•3 years ago
|
||
Brian, do you mind having a look at these r?'s?
Flags: needinfo?(bstack)
Comment 6•3 years ago
|
||
Comment on attachment 9008162 [details] Bug 1487500: allow context to be different based on parameters Brian Stack [:bstack] has approved the revision.
Attachment #9008162 -
Flags: review+
Comment 8•3 years ago
|
||
Comment on attachment 9008161 [details] Bug 1487500: improvements to create-interactive Brian Stack [:bstack] has approved the revision.
Attachment #9008161 -
Flags: review+
Assignee | ||
Comment 9•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=289dc62d3be434a219758d492556b6707b20068e
Assignee | ||
Comment 10•3 years ago
|
||
reminder to self: try an interactive task on that try push, and note flake8 errors
Comment 11•3 years ago
|
||
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d601a7868c04 improvements to create-interactive r=bstack https://hg.mozilla.org/integration/autoland/rev/bdfd4802db0c allow context to be different based on parameters r=bstack
Comment 12•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d601a7868c04 https://hg.mozilla.org/mozilla-central/rev/bdfd4802db0c
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 13•3 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-release/rev/3043bc2a9bbf https://hg.mozilla.org/releases/mozilla-release/rev/04225268cddf
status-firefox62:
--- → fixed
Comment 14•3 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/7ea780c325e4 https://hg.mozilla.org/releases/mozilla-esr60/rev/f3353aab033e
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•