1487556 - Disable the Cookies and Site Data section if Content Blocking has been turned off

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[(no longer active)]

Right now a couple of our third-party cookie blocking prefs depend on the content blocking pref.  As such, we are planning to modify the Preferences UI to disable Cookies and Site Data UI when Content Blocking has been turned off to remind users of this.

The string to be used here is:

"Your settings in Content Blocking are preventing changes to Cookies and Site Data settings."

The UX mock-up is coming up soon.

Comment 1

[Johann Hofmann [:johannh]]

Is this still for 63?

Comment 2

[(no longer active)]

I think so, yes.

Comment 3

[(no longer active)]

Attachment: Part 1: Add the required string

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 9005601 [details] [diff] [review]
Part 1: Add the required string

Review of attachment 9005601 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/browser/preferences/preferences.ftl
@@ +788,5 @@
>  
> +# This is a warning message shown next to a yellow warning icon when the Cookies and Site Data subsection
> +# in Preferences has been disabled due to Content Blocking being disabled.  It is displayed next to the
> +# Cookies and Site Data section.
> +# Note that this string hasn't yet landed in the product (see bug 1487556 for the progress on that.)

As explained in bug 1480900, I would avoid putting this kind of information in comments. 

At some point it will be enabled, and the comment will become obsolete, unless you plan to track them down and update them.

uber-nit: I'd avoid the double space after punctuation

Comment 5

[(no longer active)]

Attachment: Part 1: Add the required string

Comment 6

[(no longer active)]

Sure, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b87c8b35c101
Part 1: Add the required string; r=flod

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b87c8b35c101

Comment 9

[(no longer active)]

Attachment: Bug 1487556 - Disable the Cookies and Site Data section if Content Blocking has been turned off; r=johannh

Comment 10

[(no longer active)]

Attachment: Screenshot

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 9006395 [details]
Bug 1487556 - Disable the Cookies and Site Data section if Content Blocking has been turned off; r=johannh

Johann Hofmann [:johannh] has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14d56f95b51f
Disable the Cookies and Site Data section if Content Blocking has been turned off; r=johannh

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/14d56f95b51f

Comment 14

[(no longer active)]

Comment on attachment 9006395 [details]
Bug 1487556 - Disable the Cookies and Site Data section if Content Blocking has been turned off; r=johannh

Approval Request Comment
[Feature/Bug causing the regression]: Not a regression, enhancement to a new feature
[User impact if declined]: UI will be left in a confusing state
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Just landed.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No, the code is trivial and disabled by default.
[Why is the change risky/not risky?]: ^
[String changes made/needed]: They have landed as part 1 which is already on 63 beta.

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9006395 [details]
Bug 1487556 - Disable the Cookies and Site Data section if Content Blocking has been turned off; r=johannh

Uplift approved for 63 beta 5

Comment 16

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/64895fe611ff