Closed Bug 1487598 Opened 7 years ago Closed 7 years ago

use Atom to store pseudo-class string arguments

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Currently we use a slice of u16, since we need to pass a char16_t* to C++ code to do language tag matching. But we may as well use an Atom like with most other string storage in the style system, since atoms are already UTF-16 and null terminated.
Comment on attachment 9005549 [details] Bug 1487598 - Use an Atom to store pseudo-class string arguments. r?xidorn Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9005549 - Flags: review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c2018c83e3fd Use an Atom to store pseudo-class string arguments. r=xidorn
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: