1488013 - Cannot toggle checkbox of "All Detected Trackers"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

Reproducible: always

Steps To Reproduce:
1. Open about:preferences#privacy
2. Try toggle checkbox "All Detected Trackers"  
   (related preferences is privacy.trackingprotection.pbmode.enabled)

Actual Results:
The checkbox does not visually change anything. 
(However, the related preference is toggled)


Expected Results:
Checkbox should be toggled.

Comment 1

[Alice0775 White]

regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2667224d61d0242a29bfe2e442387a92cc58bc16&tochange=0add114333b9f0ada167bcfcda9c6167fe9079be

regressed by: Bug 1480900

Comment 2

[Eiichi]

I don't know why, but clicking "Restore Defaults" button of "Content Blocking" section fixes the issue.

Comment 3

[Eiichi]

Setting "Block cookies and site data" to "All cookies (will cause website to break)" causes the issue again.

Comment 4

[Eiichi]

(In reply to Eiichi from comment #2)
> I don't know why, but clicking "Restore Defaults" button of "Content
> Blocking" section fixes the issue.

(In reply to Eiichi from comment #3)
> Setting "Block cookies and site data" to "All cookies (will cause website to
> break)" causes the issue again.

Sorry for my spam.
I make a mistake in the bug number.

Comment 5

[(no longer active)]

Attachment: Bug 1488013 - Don't move the UI elements too early otherwise the XBL binding wouldn't have been applied when we want to adjust the checked attribute on our checkbox element; r=johannh

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9005921 [details]
Bug 1488013 - Don't move the UI elements too early otherwise the XBL binding wouldn't have been applied when we want to adjust the checked attribute on our checkbox element; r=johannh

Johann Hofmann [:johannh] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c7fc9954938
Don't move the UI elements too early otherwise the XBL binding wouldn't have been applied when we want to adjust the checked attribute on our checkbox element; r=johannh

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7c7fc9954938

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/dfc3b7ab9dff
follow-up: Make sure the test doesn't set prefs that would affect the tests following it; a=Aryx

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Firefox 63.0a1 buildID: 20180901220104.
I have tested the issue using Firefox 64.0a1 buildID: 20180909220130 and Firefox 63.0b4 buildID: 20180906162647 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13.6. The checkbox now works and changes states without issues. Marking the issue verified fixed.