Closed
Bug 1488232
Opened 6 years ago
Closed 6 years ago
Add support for using the Google Translation API
Categories
(Firefox :: Translations, enhancement)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
31.51 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Currently we support only Bing and Yandex, but it's easy to make the translation feature work with the Google API. Even if we can't ship the feature to release without an API key, people who want to try it can just signup and get their own key.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9006029 -
Flags: review?(felipc)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dabd072b63fa004e93dfffc9dc7d0e4b8078d20b
|
|
Assignee | |
Comment 3•6 years ago
|
||
Moved the & hack from TranslationDocument.jsm to GoogleTranslator.jsm per felipe's request over IRC, and unbitrotted from the changes in bug 1486739.
Attachment #9006059 -
Flags: review?(felipc)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9006029 -
Attachment is obsolete: true
Attachment #9006029 -
Flags: review?(felipc)
|
||
Updated•6 years ago
|
Attachment #9006059 -
Flags: review?(felipc) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/a3eb8e502006 add a Google translation backend, r=felipe.
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a3eb8e502006
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•