Closed Bug 1488232 Opened 2 years ago Closed 2 years ago

Add support for using the Google Translation API

Categories

(Firefox :: Translation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: florian, Assigned: florian)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Currently we support only Bing and Yandex, but it's easy to make the translation feature work with the Google API. Even if we can't ship the feature to release without an API key, people who want to try it can just signup and get their own key.
Attachment #9006029 - Flags: review?(felipc)
Attached patch Patch v2Splinter Review
Moved the & hack from TranslationDocument.jsm to GoogleTranslator.jsm per felipe's request over IRC, and unbitrotted from the changes in bug 1486739.
Attachment #9006059 - Flags: review?(felipc)
Attachment #9006029 - Attachment is obsolete: true
Attachment #9006029 - Flags: review?(felipc)
Attachment #9006059 - Flags: review?(felipc) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3eb8e502006
add a Google translation backend, r=felipe.
https://hg.mozilla.org/mozilla-central/rev/a3eb8e502006
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.