1488375 - Use target.getFront to instantiate MemoryFront

Status: RESOLVED FIXED

(DevTools :: Memory, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

Example refactoring from front instantiation to getFront --> https://phabricator.services.mozilla.com/D4579


* MemoryFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1488375 - Use target.getFront to instantiate MemoryFront; r=ochameau

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 9012628 [details]
Bug 1488375 - Use target.getFront to instantiate MemoryFront; r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1488375 - make lazyLoadFront errors more specific; r=ochameau

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4604dcda85aa
make lazyLoadFront errors more specific; r=ochameau

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4604dcda85aa

Comment 6

[Yulia Startsev [:yulia]]

try rubn: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=205031575&revision=4084fa2bba075e78ed42a92d955f413f89925f1e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ccc53c61a7
Use target.getFront to instantiate MemoryFront; r=ochameau

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 94ccc53c61a7 (Bug 1488375) for test_memory_allocations_0x.html failure.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=94ccc53c61a75edd4c218d70ab37b69e25b452df

Backout link: https://hg.mozilla.org/integration/autoland/rev/e9e765c5d7f7ec8b357f7c120aa153d1b5d18dfc 

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205081818&repo=autoland&lineNumber=107989

[task 2018-10-12T14:31:16.903Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 32 (0x7f320d110000) [pid = 4053] [serial = 553] [outer = (nil)] [url = chrome://mochitests/content/chrome/devtools/server/tests/mochitest/test_makeGlobalObjectReference.html]
[task 2018-10-12T14:31:16.904Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 31 (0x7f320f1d0800) [pid = 4053] [serial = 555] [outer = (nil)] [url = chrome://mochitests/content/chrome/devtools/server/tests/mochitest/iframe1_makeGlobalObjectReference.html]
[task 2018-10-12T14:31:16.908Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 30 (0x7f320f1dbc00) [pid = 4053] [serial = 557] [outer = (nil)] [url = chrome://mochitests/content/chrome/devtools/server/tests/mochitest/iframe2_makeGlobalObjectReference.html]
[task 2018-10-12T14:31:16.909Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 29 (0x7f320f1df400) [pid = 4053] [serial = 558] [outer = (nil)] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
[task 2018-10-12T14:31:16.910Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 28 (0x7f320e0ce000) [pid = 4053] [serial = 559] [outer = (nil)] [url = chrome://mochitests/content/chrome/devtools/server/tests/mochitest/test_memory.html]
[task 2018-10-12T14:31:16.910Z] 14:31:16     INFO - GECKO(4053) | --DOMWINDOW == 27 (0x7f320e0d3c00) [pid = 4053] [serial = 560] [outer = (nil)] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
[task 2018-10-12T14:36:15.359Z] 14:36:15     INFO - TEST-INFO | started process screentopng
[task 2018-10-12T14:36:15.752Z] 14:36:15     INFO - TEST-INFO | screentopng: exit 0
[task 2018-10-12T14:36:15.757Z] 14:36:15     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/mochitest/test_memory_allocations_01.html | Test timed out. 
[task 2018-10-12T14:36:15.757Z] 14:36:15     INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2018-10-12T14:36:15.758Z] 14:36:15     INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
[task 2018-10-12T14:36:15.759Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.759Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.760Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.761Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.761Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.762Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.763Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
[task 2018-10-12T14:36:15.763Z] 14:36:15     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a53e0884fcb1
Use target.getFront to instantiate MemoryFront; r=ochameau

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a53e0884fcb1