1485383 - Use target.getFront to instantiate all target-scoped actor fronts

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

There is still a couple of places where we instanciate the fronts manually:

* InspectorActor:
=> Dedicated bug 1485374, causes specific troubles and justify its own bug.

* CallWatcherFront:
=> Dedicated bug 1485378, it isn't a real actor and do not need a front.

* CanvasFront:
  https://searchfox.org/mozilla-central/search?q=CanvasFront(&case=false&regexp=false&path=

* WebGLFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

* WebAudioFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

* StyleSheetsFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

* StorageFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

* MemoryFront:
  https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false&regexp=false&path=

* FramerateFront:
  It is similar to CallWatcher. It isn't used by the frontend, but only by the test. It isn't really a target scoped actor, only for the test. For the frontend perspective this is only an internal call of the timeline actor. The FramerateActor isn't used anywhere, it is only used by the tests.
  https://searchfox.org/mozilla-central/search?q=FramerateActor(&case=false&regexp=false&path=
  https://searchfox.org/mozilla-central/search?q=FramerateFront&case=false&regexp=false&path=

* ReflowFront:
  https://searchfox.org/mozilla-central/search?q=ReflowFront(&case=false&regexp=false&path=

* CssPropertiesFront:
  https://searchfox.org/mozilla-central/search?q=CssPropertiesFront(&case=false&regexp=false&path=
  This one is interesting as if we drop the compatibility layer, we may be able to drop this intermediate piece of code that was doing memoization.

* CSSUsageFront:
  https://searchfox.org/mozilla-central/search?q=CssUsageFront(&case=false&regexp=false&path=
  This ony is also interesting as it workaround makeRemote while trying to memoize.

* TimelineFront:
  https://searchfox.org/mozilla-central/search?q=TimelineFront(&case=false&regexp=false&path=
  Note that this actor/front is only used for backward compat with <FF45!

* PerformanceFront:
  https://searchfox.org/mozilla-central/search?q=PerformanceFront(&case=false&regexp=false&path=
  Only tests as bug 1222047 already refactored production callsites. It may be useful to migrate initPerformance/destroyPerformance pieces to fronts.
  https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/devtools/client/framework/toolbox.js#3087-3116

* AnimationsFront:
  https://searchfox.org/mozilla-central/search?q=animationsfront(&case=false&regexp=false&path=

* PromisesFront:
  https://searchfox.org/mozilla-central/search?q=PromisesFront(&case=false&regexp=false&path=
  Only used by test, we may try to remove this actor/front?

* EmulationFront:
  https://searchfox.org/mozilla-central/search?q=EmulationFront(&case=false&regexp=false&path=

* WebExtensionInspectedWindowFront:
  https://searchfox.org/mozilla-central/search?q=WebExtensionInspectedWindowFront(&case=false&regexp=false&path=

* AccessibilityFront:
  https://searchfox.org/mozilla-central/search?q=AccessibilityFront(&case=false&regexp=false&path=

Comment 1

[Yulia Startsev [:yulia]]

It looks like this is mostly done. this is the remaining issue:

Emulation front: https://searchfox.org/mozilla-central/search?q=EmulationFront(&case=false&regexp=false&path

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1485383 - update emulationFront to be retrieved using getFront; r=jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a679cbe3aac3
update emulationFront to be retrieved using getFront; r=jdescottes

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a679cbe3aac3