Closed
Bug 1488380
Opened 6 years ago
Closed 6 years ago
Use target.getFront to instantiate EmulationFront
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
Details
(Whiteboard: dt-fission)
Attachments
(1 file, 2 obsolete files)
Example refactoring from front instantiation to getFront --> https://phabricator.services.mozilla.com/D4579 * EmulationFront: https://searchfox.org/mozilla-central/search?q=EmulationFront(&case=false®exp=false&path=
Assignee | ||
Comment 1•6 years ago
|
||
This is one option for updating the emulation front. It leaves the emulation front untouched in the responsive.html manager, as there is a comment that we want to connect to the tab with another server
Assignee | ||
Comment 2•6 years ago
|
||
This is another approach to the emulationFront update. In testing, I couldn't see a difference in the behavior in this appraoch and the original appraoch. The difference here, it looks like anyway, is that instead of having two debugger servers for the same target, we have just one. Depends on D7880
Updated•6 years ago
|
Attachment #9014807 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9014799 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4bdaf04bcb7 update RDM emulation front instantiation with comments, move to getFront elsewhere; r=ochameau
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4bdaf04bcb7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Assignee: nobody → ystartsev
Updated•6 years ago
|
Whiteboard: dt-fission
You need to log in
before you can comment on or make changes to this bug.
Description
•