148840 - Add "Bookmark This Group of Tabs..." to Bookmarks menu

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[jag (Peter Annema)]

Add "Bookmark This Group of Tabs..." to Bookmarks menu to make it easier to
discover this feature.

Comment 1

[jag (Peter Annema)]

Attachment: Add menuitem

Comment 2

[Joe Hewitt (gone)]

Comment on attachment 86102 [details] [diff] [review]
Add menuitem

sr=hewitt

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 86102 [details] [diff] [review]
Add menuitem

>-               currentTabInfo.charset, "addGroup", tabsInfo);
>+               currentTabInfo.charset, "addGroup"+(aSelect?",group":""), tabsInfo);

Fix the spacing there (that's hard to read) and r=caillon with that nit picked.

Comment 4

[Peter Trudelle]

nsbeta1+/adt2

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 86102 [details] [diff] [review]
Add menuitem

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 6

[Syd Logan]

adding adt1.0.1+ on behalf of ADT

Comment 7

[Travis Crump]

  When you click on this new menu item, the checkbox to Bookmark this group of
tabs is still present, but it is impossible to get it into a visibly checked
state even though the initial state of the dialog is consistent with it being
checked and a group is still added if you OK the bookmark when the Location
field is inactive.

Comment 8

[jag (Peter Annema)]

Bah. You'll see it sets the checkbox just fine when you open the dialog for the
second time. For some reason the checkbox's binding hasn't finished loading yet
at that point, so using .checked won't work. It's the same reason the dialog
isn't sized correctly the first time you open it. Oh well, patch coming up.

Comment 9

[jag (Peter Annema)]

Attachment: Work around checkbox xbl not being done loading at onload

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 86304 [details] [diff] [review]
Work around checkbox xbl not being done loading at onload

r=caillon

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 86304 [details] [diff] [review]
Work around checkbox xbl not being done loading at onload

sr=jst

Comment 12

[Michele Carlson]

l10n approved. Please check this into the branch by Weds. thanks

Comment 13

[jag (Peter Annema)]

Checked in on trunk and branch.

Comment 14

[Hixie (not reading bugmail)]

Shouldn't this have got module owner approval?

Anyway, for me, on the trunk, this doesn't work. I get a dialog saying that
Mozilla couldn't reach http://www.bookmark_groupmark.com/. FWIW.

Comment 15

[Hixie (not reading bugmail)]

I can't reproduce that now, but it definitely happened once. When it did, no
bookmark filing window came up, if that is relevant.

Comment 16

[Travis Crump]

Steps to reproduce Ian's error that work for me:
1)  Load a bookmark group
2)  While the tabs are still loading(some of the tabs still say 'Loading' and
haven't even retrieved the title[once all the pages have a title this doesn't
seem to happen]), click on Bookmark this Group of Tabs.
3)  Mozilla attempts to load bookmarks_groupmark[followed by
www.bookmarks_groupmark.com due to another bug]

I was just able to reproduce this three times in a row.

Comment 17

[Peter Trudelle]

Please file a new bug on that.

Comment 18

[Travis Crump]

filed bug 150472

Comment 19

[Claudius Gayle]

VERIFIED FIxed on 20020627 branch and trunk builds

Comment 20

[Ben Bucksch (:BenB)]

Counter bug 156121 filed.

Comment 21

[HJ]

FYI: that menu item is visible all the time, even when you have only one tab
open and that should not be the case.