1488660 - DevTools tab reordering is not working in RTL locales

Status: VERIFIED FIXED

(DevTools :: Framework, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Some comparisons made in devtools/client/framework/toolbox-tabs-order-manager.js assume LTR layout and make the feature buggy for RTL locales.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Screencast.gif

Comment 3

[Julian Descottes [:jdescottes]]

Screencast above was initially uploaded by contributor Itiel on duplicate Bug 1494261.

Comment 4

[Julian Descottes [:jdescottes]]

For the record most of the issue comes from the logic at https://searchfox.org/mozilla-central/rev/ffe6eaf2f032e58ec3b0650a87df2c62ae4ca441/devtools/client/framework/toolbox-tabs-order-manager.js#105

All the "greater than" and "lower than" comparisons are assuming LTR order. We should either check the document direction and change the logic based on that, or attempt to have something that works well for both RTL and LTR.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1488660 - Fix devtools tab reordering in RTL locales;r=daisuke

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6fb38d05c8
Fix devtools tab reordering in RTL locales;r=daisuke

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ed6fb38d05c8

Comment 8

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 64.0a1 (2018.09.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 65.0a1 on Win 10 x64, Ubuntu 18.04 x64 and Mac OS X 10.13.6.