Closed Bug 1488660 Opened Last year Closed Last year

DevTools tab reordering is not working in RTL locales

Categories

(DevTools :: Framework, defect, P3)

defect

Tracking

(firefox65 verified)

VERIFIED FIXED
Firefox 65
Tracking Status
firefox65 --- verified

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(2 files)

Some comparisons made in devtools/client/framework/toolbox-tabs-order-manager.js assume LTR layout and make the feature buggy for RTL locales.
Duplicate of this bug: 1494261
Attached image Screencast.gif
Screencast above was initially uploaded by contributor Itiel on duplicate Bug 1494261.
For the record most of the issue comes from the logic at https://searchfox.org/mozilla-central/rev/ffe6eaf2f032e58ec3b0650a87df2c62ae4ca441/devtools/client/framework/toolbox-tabs-order-manager.js#105

All the "greater than" and "lower than" comparisons are assuming LTR order. We should either check the document direction and change the logic based on that, or attempt to have something that works well for both RTL and LTR.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed6fb38d05c8
Fix devtools tab reordering in RTL locales;r=daisuke
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed6fb38d05c8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
I have reproduced this issue using Firefox 64.0a1 (2018.09.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 65.0a1 on Win 10 x64, Ubuntu 18.04 x64 and Mac OS X 10.13.6.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.