1488713 - Translated element in rotated container gets cut off

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Magne Andersson]

Attachment: example1.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20180904220134

Steps to reproduce:

The attached test case includes two rows of rounded boxes inside a rotated container. The first row has a translateX() transformation applied, which incorrectly causes the boxes to get cut off. The second row acts as a reference.

I'm only seeing this in Firefox Nightly, and not in latest Servo.

Comment 1

[Magne Andersson]

Attachment: example1-screenshot.png

Comment 2

[Darkspirit]

Thanks!

mozregression --good 2018-07-01 --bad 2018-09-05 --pref gfx.webrender.all:true -a https://bug1488713.bmoattachments.org/attachment.cgi?id=9006526
> 7:54.85 INFO: Last good revision: 43b1ea339d12e26266d7946b74eb0a7304157aa6
> 7:54.85 INFO: First bad revision: 82efdb13962c299f4501c9f4ee3a4608a4fef85a
> 7:54.85 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=43b1ea339d12e26266d7946b74eb0a7304157aa6&tochange=82efdb13962c299f4501c9f4ee3a4608a4fef85a

> 82efdb13962c	Jeff Muizelaar — Bug 1487429. Update tests for WebRender changes.
> 595a9385a0b0	Jeff Muizelaar — Bug 1487429. Update webrender to 69dae1fe743bf3656d532672366e7193b041b6f7

Regression range: https://github.com/servo/webrender/compare/5fa5c46e167ca834d8fec3bf662bf420418698f4...69dae1fe743bf3656d532672366e7193b041b6f7
= servo/webrender#2995

(I am not sure whether this is a duplicate of bug 1487984 or not.)

Comment 3

[Glenn Watson [:gw]]

When testing on Gecko with my (local) transform changes, this draws correctly with WR. So it's likely to be fixed with the next WR update (depending on how long it takes to get this patch landed).