Closed Bug 1488720 Opened 6 years ago Closed 6 years ago

Quick share icons are too large

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox62 verified, firefox63 verified, firefox64 verified)

VERIFIED FIXED
Firefox 64
Tracking Status
firefox62 --- verified
firefox63 --- verified
firefox64 --- verified

People

(Reporter: ohorvath, Assigned: petru)

References

Details

(Keywords: regression)

Attachments

(3 files)

Devices:
Google Pixel C Android 8.0.0
Samsung Galaxy S8+ Android 8.0.0
OnePlus 3 (Android 6.0.1)
Nexus 9	(Android 6.0.1)
*NR: Devices with Android 5

Build: Nightly 63.0a1 (2018-08-05)

Steps to reproduce:
1. Open a webpage.
2. Open the custom menu, select Share and tap on a sharing option.
3. Re-open the custom menu and observe the quick share icons.

Expected result:
Regular size icons.

Actual result:
Icons are too large (see screenshot).

Regression window:
Last good build: 2018-08-29
First bad build: 2018-08-30

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b75561ff5ffec3164338952adfe58620e5e3bc1d&tochange=815b46ed118286d682ce258e6147df5dc691eabf

DEBUG : Found commit message:
Bug 1486200 - Apply Photon theme for Date/Time pickers only on API >=23; r=jchen

Fix Lollipop crashes because of android.content.res.ColorStateList.addFirstIfMissing()
The default app theme will be applied for the material Date/Time pickers on
API 21 and API 22. After this, on API >=23 they will be Photon themed.
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
The issue in this ticket was because of missing menuItemSecondaryActionBarStyle,
property of the menu items shown in the SecondaryActionBar.

The GeckoAppBase style from values-v23/themes.xml contained the properties
initially defined in the general values/themes.xml.
Now changed to contain the properties from the closest values-v21/themes.xml.
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9006556 - Flags: review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1dfab9dd166
[Android M+] improve themes.xml; r=jchen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c1dfab9dd166
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Flags: qe-verify+
Verified as fixed on Nightly 64 (2018-09-07).
Devices:
Google Pixel (Android 9)
OnePlus 5T (Android 8.0)
Flags: qe-verify+
Petru, can you make a patch for an uplift to beta and request that uplift? Thanks
Flags: needinfo?(petru.lingurar)
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1486200
[User impact if declined]: Small visual defect - Icons in the share menu appear slightly larger.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Little change, has been verified in Nightly.
[String changes made/needed]: --
Flags: needinfo?(petru.lingurar)
Attachment #9006556 - Flags: approval-mozilla-beta?
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1486200
[User impact if declined]: Small visual defect - Icons in the share menu appear slightly larger.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Little change, has been verified in Nightly.
[String changes made/needed]: --
Attachment #9006556 - Flags: approval-mozilla-release?
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

Uplift approved for 63 beta 5
Attachment #9006556 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

IMO a "small defect" doesn't warrant dot release inclusion
Attachment #9006556 - Flags: approval-mozilla-release? → approval-mozilla-release-
Verified as fixed on latest Beta build - 63.0b5.
Device: Google Pixel C(Android 8.0.0). Following the steps from the description.
Status: RESOLVED → VERIFIED
(In reply to Julien Cristau [:jcristau] from comment #10)
> Comment on attachment 9006556 [details]
> Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani
> 
> IMO a "small defect" doesn't warrant dot release inclusion

Depends - does this count as small?
Flags: needinfo?(jcristau)
Comment on attachment 9006556 [details]
Bug 1488720 - [Android M+] improve themes.xml; r=sdaswani

I guess not.  I was going by the description in comment 12.

Approved for 62.0.2
Flags: needinfo?(jcristau)
Attachment #9006556 - Flags: approval-mozilla-release- → approval-mozilla-release+
Verified as fixed on the latest version of Firefox Release (62.0.2) with OnePlus 3 (Android 6.0.1) and Nokia 6 (Android 7.1.1).
Not sure if it is related but the popup shows wrong icon sizes when using the share link menu. See screenshot.

How to reproduce: long press on a link and select the share button.

Android 8.1 / Firefox 62.0.2
(In reply to Ralf from comment #20)
> Created attachment 9011205 [details]
> Wrong icon sizes in share link popup
> 
> Not sure if it is related but the popup shows wrong icon sizes when using
> the share link menu. See screenshot.
> 
> How to reproduce: long press on a link and select the share button.
> 
> Android 8.1 / Firefox 62.0.2

The bug 1397174 it's filed for your issue, if you want to add some information please write it there, thanks.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: