1486200 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method 'int android.widget.DatePicker.getYear()' on a null object reference at org.mozilla.gecko.prompts.PromptInput$DateTimeInput.getValue(PromptInput.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-011031dc-4aaa-4510-9b24-43ac90180819.
=============================================================

java.lang.NullPointerException: Attempt to invoke virtual method 'int android.widget.DatePicker.getYear()' on a null object reference
	at org.mozilla.gecko.prompts.PromptInput$DateTimeInput.getValue(PromptInput.java:269)
	at org.mozilla.gecko.prompts.PromptInput.putInBundle(PromptInput.java:388)
	at org.mozilla.gecko.prompts.Prompt.addInputValues(Prompt.java:302)
	at org.mozilla.gecko.prompts.Prompt.cancelDialog(Prompt.java:515)
	at org.mozilla.gecko.prompts.Prompt.addInputs(Prompt.java:466)
	at org.mozilla.gecko.prompts.Prompt.create(Prompt.java:237)
	at org.mozilla.gecko.prompts.Prompt.createPrompt(Prompt.java:175)
	at org.mozilla.gecko.prompts.Prompt.show(Prompt.java:138)
	at org.mozilla.gecko.prompts.Prompt.show(Prompt.java:112)
	at org.mozilla.gecko.prompts.PromptService.handleMessage(PromptService.java:49)
	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:344)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5219)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694) 

=============================================================

There are 25 crashes (from 10 installations) in 62.0b17 starting with buildid 20180813190114. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1474888.

[1] https://hg.mozilla.org/releases/mozilla-beta/rev?node=ebf6855161a1

Comment 1

[Julien Cristau [:jcristau]]

flagging for tracking as a late regression in b17

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I'm going to assume this'll show up on 63 as well once it hits Beta next week. It's pretty dicey getting a fix for this into 62 still, but we could probably swing it if a patch materializes soon.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1486200 - Apply Photon theme for Date/Time pickers only on API >=23; r=sdaswani

Fix Lollipop crashes because of android.content.res.ColorStateList.addFirstIfMissing()
The default app theme will be applied for the material Date/Time pickers on
API 21 and API 22. After this, on API >=23 they will be Photon themed.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Regression was introduced by the first patch for bug 1412518.
Happens only on Lollipop because of
> java.lang.ArrayIndexOutOfBoundsException: length=1; index=1
>        at android.content.res.ColorStateList.addFirstIfMissing(ColorStateList.java:356)
,method which was a workaround on the then ColorStateList limitations [1].

Because of this I propose only applying the new Photon theme for Android versions newer than Lollipop.

[1] https://chromium.googlesource.com/android_tools/+/78ccfd5f7e4880597fd90c61453a3be0e7aee5f0/sdk/sources/android-21/android/content/res/ColorStateList.java#339

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Susheel, not sure if you saw the review request or not (yay Phabricator). Can you please take a look?

Comment 6

[:sdaswani]

Ryan I handed off that review to jchen given I'm not comfortable reviewing it.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9004605 [details]
Bug 1486200 - Apply Photon theme for Date/Time pickers only on API >=23; r=sdaswani

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eedde033c21
Apply Photon theme for Date/Time pickers only on API >=23; r=jchen

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6eedde033c21

Comment 10

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 63 (2018-08-30), along with bug 1483165.
Mi 4i (Android 5.0.2).
Huawei MediaPad M2 (Android 5.1.1)

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9004605 [details]
Bug 1486200 - Apply Photon theme for Date/Time pickers only on API >=23; r=sdaswani

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1412518
[User impact if declined]: Trying to input date/time crashes the app on Lollipop
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change, QA verified
[String changes made/needed]: --

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9004605 [details]
Bug 1486200 - Apply Photon theme for Date/Time pickers only on API >=23; r=sdaswani

Fixes a new crash in Fx62 and verified by QA. Approved for Fx62 RC2.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/9cbae12a3fff

Comment 14

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on RC 62.0 build 2, along with bug 1483165.
Mi 4i (Android 5.0.2).
Huawei MediaPad M2 (Android 5.1.1)