Closed Bug 1488789 Opened 7 years ago Closed 7 years ago

Use tc-lib-pulse in taskcluster-auth

Categories

(Taskcluster :: Services, enhancement)

Product:
Taskcluster
Component:
Services
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

References

Details

Switch from using PulseListener to using tc-lib-pulse to consume and produce messages.
Assignee: nobody → dustin
Blocks: 1499190
Blocks: 1498700
2018-10-17T19:10:33.232016+00:00 app[web.2]: AssertionError [ERR_ASSERTION]: credentials is required 2018-10-17T19:10:33.232046+00:00 app[web.2]: at Object.claimedCredentials (/app/node_modules/taskcluster-lib-pulse/src/credentials.js:58:3) 2018-10-17T19:10:33.232050+00:00 app[web.2]: at setup (/app/src/main.js:155:31) because auth doesn't have a static client. Hmm.
Setting up a static client leads to an H20 app boot timeout. I had forgotten that consuming blocks until the channel is created, which requires a connection, which requires credentials, which requires a call to tc-pulse, which in turn calls authenticate-hawk, which isn't available yet. So, auth can't use tc-pulse.
Commits pushed to master at https://github.com/taskcluster/taskcluster-auth https://github.com/taskcluster/taskcluster-auth/commit/f8269df84dbfe5c80ec7262a660be99285c787c8 Revert "Bug 1488789 - provide taskcluster credentials for use with tc-pulse" This reverts commit 66f7ffd1d4d04a22b7394bfb249f1d947d00b971. https://github.com/taskcluster/taskcluster-auth/commit/7ddbd25f01872d28f1cdaf7c9ae7a3ae7ad51f31 Revert "Merge pull request #170 from djmitche/bug1488789" This reverts commit 40e44eacf15ed2b40e309f16ec909a08b08b33c0, reversing changes made to 9d93656b73593331a9e01bfe76e757a75114fafc.
I backed out all of the above in the repo. Current HEAD is the same as 9d93656b73593331a9e01bfe76e757a75114fafc.
No longer blocks: 1499190
https://github.com/taskcluster/taskcluster-auth/pull/171 That follows the new plan of using tc-lib-pulse but not communicating with tc-pulse (so, using static pulse credentials)
Backed that one out, too. `consume(..)` is only for permanent consumers, but auth needs one ephemeral consumer per process.
Depends on: 1500216
Commit pushed to master at https://github.com/taskcluster/taskcluster-auth https://github.com/taskcluster/taskcluster-auth/commit/bcd02063f724c810d87b2270d68a9c302d305499 Revert "Merge pull request #171 from djmitche/bug1488789" This reverts commit c5f1b3d46754b278acf91380b1b5b9b76cc42311, reversing changes made to 37b71bface82b73f293edced091bb63f3013db06.
Commits pushed to master at https://github.com/taskcluster/taskcluster-auth https://github.com/taskcluster/taskcluster-auth/commit/651b2f813a43b9037f8072b8e1d722fc6c47dd0c Bug 1488789 - use tc-lib-pulse For real this time! * Use configured pulse credentials, so no dependency on another service * Use ephemeral consumers for the "notification" pulse messages https://github.com/taskcluster/taskcluster-auth/commit/91168809cf79ba3f9409b19045b1b0cda75348a1 Merge pull request #173 from djmitche/bug1488789 Bug 1488789 - use tc-lib-pulse
OK, looks like that one stuck.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Platform and Services → Services
You need to log in before you can comment on or make changes to this bug.