Closed Bug 1488807 Opened 2 years ago Closed 2 years ago

[de-xbl] Remove dialogheader binding.

Categories

(Thunderbird :: Account Manager, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: arshad, Assigned: arshad)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 5 obsolete files)

dialogheader has description attribute[1] which is never used except one time in /suite[2]. I am thinking of converting it into custom element. Should I add dialogheader-description or not into the new element?

[1]: https://searchfox.org/comm-central/source/common/bindings/generalBindings.xml#45
[2]: https://searchfox.org/comm-central/search?q=(%3Cdialogheader+.%2B+description)&case=false&regexp=true&path=
Assignee: nobody → arshdkhn1
Flags: needinfo?(mkmelin+mozilla)
Attached patch dialogheader.patch (obsolete) — Splinter Review
Attachment #9006669 - Flags: review?(mkmelin+mozilla)
Looking at the few isolated usages of dialogheader, it seems to me it would be preferable to get rid of this element by open coding it. It woudl be replaced by a label (and perhaps a containing box?) easily. There's no functionality, only some css.

That said, don't let it stop the work you're doing to get the "infrastructure" set up (customElements.js file) as that would be useful elsewhere.

So to answer what to do with the description: nothing.

Makes sense?
Flags: needinfo?(mkmelin+mozilla)
Comment on attachment 9006669 [details] [diff] [review]
dialogheader.patch

For WIP patches, ask for feedback only.
When you think the patch is ready, then ask for review.
Attachment #9006669 - Attachment is obsolete: true
Attachment #9006669 - Flags: review?(mkmelin+mozilla)
Attached patch dialogheader.patch (obsolete) — Splinter Review
Attached patch dialogheader.patch (obsolete) — Splinter Review
Attachment #9006911 - Attachment is obsolete: true
Attached patch dialogheader.patch (obsolete) — Splinter Review
Attachment #9006922 - Attachment is obsolete: true
Attachment #9006932 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9006932 [details] [diff] [review]
dialogheader.patch

Review of attachment 9006932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=mkmelin

::: mailnews/base/prefs/content/am-main.js
@@ +15,4 @@
>    else
>      titleValue = defaultTitle;
>  
> +  title.setAttribute("value",titleValue);

let's add the missing space after comma while we're here
Attachment #9006932 - Flags: review?(mkmelin+mozilla) → review+
Is there a second patch / follow-up bug and patch coming for the suite/ parts?
Flags: needinfo?(arshdkhn1)
Status: NEW → ASSIGNED
Attached patch dialogheader.patch (obsolete) — Splinter Review
Added the white space.
Attachment #9006932 - Attachment is obsolete: true
Flags: needinfo?(arshdkhn1)
(In reply to Ian Neal from comment #8)
> Is there a second patch / follow-up bug and patch coming for the suite/
> parts?

I am not sure whether I have to create a second patch / follow-up bug for suite. I think Magnus will be right person to ask this.
I don't think we should fix up suite here. But we can clone the bug to suite and let seamonkey people handle suite/ parts there.
Blocks: 1490979
Attachment #9007411 - Attachment is obsolete: true
Attachment #9014328 - Flags: review+
Keywords: checkin-needed
(In reply to Jorg K (GMT+2) from comment #13)
> You guys got a try run? Here we go:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=e9802ed9dc90642b6f734c2c990d44c8734d57f3

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=055078b0ca59fac37b8858df54d68cf34065101f

Sorry i forgot to comment it.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5e8a03122a95
Removing dialogheader binding; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Depends on: 1498902
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.