1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled

Status: RESOLVED FIXED

(Firefox :: Private Browsing, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

We have a different onboarding for CB and we need to make sure to link to it from about:privatebrowsing.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs

Comment 2

[:Gijs (he/him)]

Comment on attachment 9006716 [details]
Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs

:Gijs (he/him) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e57c8ca8d1b
Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs

Comment 4

[(no longer active)]

This needs a backport, right?

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9006716 [details]
Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs

Approval Request Comment
[Feature/Bug causing the regression]: UI Tour changes in bug 1484585
[User impact if declined]: Users won't get the correct UI Tour for the new Content Blocking feature if they visit it from about:privatebrowsing.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Hard to test right now, since the backend is not in place yet. But it's a very simple patch so it shouldn't be necessary.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Very simple patch that only updates a link on about:privatebrowsing
[String changes made/needed]: None

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4e57c8ca8d1b

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006716 [details]
Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs

Uplift approved for 63 beta 5

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/245f57954951