Closed Bug 1489095 Opened 7 years ago Closed 7 years ago

nsITooltipListener use XPCOM strings

Categories

(Core :: General, enhancement, P5)

Product:
Core
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: hsivonen, Assigned: ryan.k.scherich)

Details

(Keywords: good-first-bug, Whiteboard: [mentor=hsivonen])

Attachments

(1 file)

Bug 1489095 - Change nsITooltipListener to use XPCOM strings.
47 bytes, text/x-phabricator-request
Details | Review
nsITooltipListener is only used from C++. While at it, please convert the const char16_t* arguments of OnShowTooltip to const nsAString&.
I don't think doing this will allow us to remove any XPCOM registrations right? So it's not related to bug 1477576...
(In reply to :Ehsan Akhgari from comment #1) > I don't think doing this will allow us to remove any XPCOM registrations > right? So it's not related to bug 1477576... Good point. Sorry.
Blocks: deCOM
No longer blocks: 1477576
Keywords: good-first-bug
(Moving to Core -- no front-end or /toolkit code seems to be involved here.)
Product: Toolkit → Core
(In reply to Henri Sivonen (:hsivonen) from comment #0) > nsITooltipListener is only used from C++. > > While at it, please convert the const char16_t* arguments of OnShowTooltip > to const nsAString&. Can you provide a little more context for a first time bugzillian? Thanks! Also, would you be a good mentor?
Flags: needinfo?(hsivonen)
Priority: -- → P5
(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #4) > > While at it, please convert the const char16_t* arguments of OnShowTooltip > > to const nsAString&. > > Can you provide a little more context for a first time bugzillian? Thanks! On a closer look, the string part is a good first bug. DeCOMtamination isn't. The general guidance for the string part is: "Change wstring to AString in the IDL and then fix the compiler errors." > Also, would you be a good mentor? I marked myself as a mentor.
No longer blocks: deCOM
Flags: needinfo?(hsivonen)
Summary: DeCOMtaminate nsITooltipListener → nsITooltipListener use XPCOM strings
Whiteboard: [mentor=hsivonen]
Can I work on this bug?

Looks like this is basically ready to land.

Assignee: nobody → ryan.k.scherich
Keywords: checkin-needed

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/745be69de37d
Change nsITooltipListener to use XPCOM strings. r=hsivonen

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/745be69de37d

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Thanks for fixing this!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: