nsITooltipListener use XPCOM strings

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P5
normal
RESOLVED FIXED
10 months ago
5 months ago

People

(Reporter: hsivonen, Assigned: ryan.k.scherich)

Tracking

({good-first-bug})

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [mentor=hsivonen])

Attachments

(1 attachment)

Reporter

Description

10 months ago
nsITooltipListener is only used from C++.

While at it, please convert the const char16_t* arguments of OnShowTooltip to const nsAString&.

Comment 1

10 months ago
I don't think doing this will allow us to remove any XPCOM registrations right?  So it's not related to bug 1477576...
Reporter

Comment 2

9 months ago
(In reply to :Ehsan Akhgari from comment #1)
> I don't think doing this will allow us to remove any XPCOM registrations
> right?  So it's not related to bug 1477576...

Good point. Sorry.
Blocks: deCOM
No longer blocks: 1477576
Reporter

Updated

9 months ago
Keywords: good-first-bug
(Moving to Core -- no front-end or /toolkit code seems to be involved here.)
Product: Toolkit → Core
(In reply to Henri Sivonen (:hsivonen) from comment #0)
> nsITooltipListener is only used from C++.
> 
> While at it, please convert the const char16_t* arguments of OnShowTooltip
> to const nsAString&.

Can you provide a little more context for a first time bugzillian? Thanks!

Also, would you be a good mentor?
Flags: needinfo?(hsivonen)
Priority: -- → P5
Reporter

Comment 5

9 months ago
(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #4)
> > While at it, please convert the const char16_t* arguments of OnShowTooltip
> > to const nsAString&.
> 
> Can you provide a little more context for a first time bugzillian? Thanks!

On a closer look, the string part is a good first bug. DeCOMtamination isn't.

The general guidance for the string part is:

"Change wstring to AString in the IDL and then fix the compiler errors."

> Also, would you be a good mentor?

I marked myself as a mentor.
No longer blocks: deCOM
Flags: needinfo?(hsivonen)
Summary: DeCOMtaminate nsITooltipListener → nsITooltipListener use XPCOM strings
Whiteboard: [mentor=hsivonen]
Assignee

Comment 6

6 months ago
Can I work on this bug?

Looks like this is basically ready to land.

Assignee: nobody → ryan.k.scherich
Keywords: checkin-needed

Comment 9

5 months ago

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/745be69de37d
Change nsITooltipListener to use XPCOM strings. r=hsivonen

Keywords: checkin-needed

Comment 10

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Reporter

Comment 11

5 months ago

Thanks for fixing this!

You need to log in before you can comment on or make changes to this bug.