1489168 - Firefox nightly can't launch after update

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[pierre.goffic]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce:

Hello,
i have update firefox nightly on my One plus 3t.



Actual results:

After this, firefox nightly is crash, i have try to reboot my phone but i have the same result : i can't launch firefox nightly

Comment 1

[pierre.goffic]

(In reply to pierre.goffic from comment #0)
> User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36
> (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36
> 
> Steps to reproduce:
> 
> Hello,
> i have update firefox nightly on my One plus 3t.
> 
> 
> 
> Actual results:
> 
> After this, firefox nightly is crash, i have try to reboot my phone but i
> have the same result : i can't launch firefox nightly

Sorry but i can't send any report because i can't start the application.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Jan, this seems to have been caused by your recent patch for bug 1488174

Stacktrace:
> java.lang.UnsupportedOperationException
>        at java.util.AbstractList.add(AbstractList.java:148)
>        at java.util.AbstractList.add(AbstractList.java:108)
>        at org.mozilla.gecko.notifications.NotificationHelper.initNotificationChannels(NotificationHelper.java:198)
>        at org.mozilla.gecko.notifications.NotificationHelper.init(NotificationHelper.java:175)
>        at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java:347)

Comment 3

[Oana Horvath [:ohorvath - out of office]]

Attachment: nightly launch crash log.txt

Comment 4

[Marcia Knous [:marcia]]

I see this as well. RyanVM mentions a backout and respin is forthcoming.

Comment 6

[Jan Henning [:JanH]]

(In reply to Petru-Mugurel Lingurar[:petru] from comment #2)
> Jan, this seems to have been caused by your recent patch for bug 1488174

Indeed, sorry for not catching this. Unfortunately I cannot easily test on O and in any case the crash only happens when installing from the Play Store, so wouldn't show up in local testing anyway. At least that means that people using the built-in updater should be unaffected.

Comment 7

[pierre.goffic]

Hi,
thanks for your reply and your update.
I have receive an update and now it's works :)

if the problem coming from the fact that i use play store how can I try the built-in updater in android ?

Comment 8

[Jan Henning [:JanH]]

Marking as fixed by the backout then: https://hg.mozilla.org/mozilla-central/rev/54cd02c97ed4

@Pierre:
Sorry for the inconvenience. As for your question, the updater only works on Nightly and even there turns itself off if Firefox was originally installed through the Play Store, because apps on the Play Store aren't allowed to update themselves. As far as I know, the only way to reset that is by completely un- and then reinstalling Firefox from e.g. https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-central-android-api-16/. That would reset your profile, though, so unless you're rooted and could backup your profile I wouldn't recommend it.

Comment 9

[:gerard-majax]

(In reply to Marcia Knous [:marcia - needinfo? me] from comment #4)
> I see this as well. RyanVM mentions a backout and respin is forthcoming.

I can confirm this reached Play Store and it indeed fixed the issue for me.

Comment 10

[Jan Henning [:JanH]]

(In reply to Jan Henning [:JanH] from comment #6)
> so wouldn't show up in local testing anyway.

Actually no, while I obviously can't go through the "installed from Play Store" part with a local build, on the other hand I presume that MOZ_UPDATER would be false for a local build and so you would still hit the crashing code path - but only when testing on Android O or above.

Comment 11

[Oana Horvath [:ohorvath - out of office]]

Verified the Play store build is working now. Closing as verified.