Closed Bug 1488174 Opened 6 years ago Closed 6 years ago

Follow-up to bug 1479532 - only use Updater notification channel when not installed from Google Play

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 63
All
Android
defect
Not set
normal

Tracking

(firefox63 wontfix, firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file)

Currently, I'm only checking the MOZ_UPDATER build define, which should exclude Beta and Release, but I should additionally be checking the installation source as well, so the notification channel only shows up on Nightly builds *not* installed from the Play Store.
That way, we only add that notification channel if the updater really is active,
i.e. not if we've been installed from the Play Store.
Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re-
moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation.
Depends on: 1482105
No longer depends on: 1479532
Comment on attachment 9006163 [details]
Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9006163 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/b9e56df24edc
Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
https://hg.mozilla.org/mozilla-central/rev/b9e56df24edc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 64 → ---
Backout by ccoroiu@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/54cd02c97ed4
Backed out changeset b9e56df24edc for fennec crashing at startup a=backout
This got backed out request from QA and the SoftVision Android developers:

https://hg.mozilla.org/mozilla-central/rev/54cd02c97ed4

Tracked in bug 1489168.
Blocks: 1489168
Flags: needinfo?(jh+bugzilla)
Hmm, it seems the ArrayList returned from Arrays.asList isn't actually extendable.
Flags: needinfo?(jh+bugzilla)
Beta and Release have MOZ_UPDATER as false, so no need to uplift.
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/e74bd1eae0db
Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
https://hg.mozilla.org/mozilla-central/rev/e74bd1eae0db
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: