1489295 - Support column-span for columns on <button>

Status: RESOLVED FIXED

(Core :: Layout: Columns, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Bug 1421105 implements "column-span" for block and inline frames only. fieldset [1] and button [2] are still using `InitAndWrapInColumnSetFrameIfNeeded()` to construct column hierarchy, which is unware of "column-span". We'll need to adjust them to support column-span.

[1] https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/layout/base/nsCSSFrameConstructor.cpp#3277
[2] https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/layout/base/nsCSSFrameConstructor.cpp#3876

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I filed bug 1535200 for supporting column-span on <fieldset>, and morph this one for supporting column-span on <button>

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1489295 Part 1 - Rename frame construction data bit that creates flex/grid/column.

After supporting column-span, the top-level container for multicol
layout is no longer the ColumnSetFrame, so remove the "SET" suffix from
FCDATA_ALLOW_GRID_FLEX_COLUMNSET bit to make it sound more general.

Also, update the document and add an assertion.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1489295 Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal().

Rename outerSC to outerStyle because nsStyleContext was gone.

Depends on D24394

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1489295 Part 3 - Implement column-span:all for <button>.

We need to pull outerFrame one level up to the outer scope because it's
needed when calling FinishBuildingColumns().

The patch is very similar to implementing column-span:all for <fieldset>
in bug 1535200.

Depends on D24395

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1489295 Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded().

The last consumer of the method is removed in Part 3.

Depends on D24396

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6d13b9a5c5c
Part 1 - Rename frame construction data bit that creates flex/grid/column. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/d53a78255fdb
Part 2 - Clean up the naming of a 'nsStyleContext' variable in ConstructFrameFromItemInternal(). r=dbaron
https://hg.mozilla.org/integration/autoland/rev/804b15f4d229
Part 3 - Implement column-span:all for <button>. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/989c26cee557
Part 4 - Remove InitAndWrapInColumnSetFrameIfNeeded(). r=dbaron

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c6d13b9a5c5c
https://hg.mozilla.org/mozilla-central/rev/d53a78255fdb
https://hg.mozilla.org/mozilla-central/rev/804b15f4d229
https://hg.mozilla.org/mozilla-central/rev/989c26cee557

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16093 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/16093
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/K6FSnzYzRniCAYIbApBE-g)