1489402 - Middle-clicking a link from the address bar dropdown that is overflowing it will apply the fading effect on the URL's host name

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Itiel]

Attachment: Screencast

Using latest Nightly, Windows 10 x86.

STR:
Open any URL (long enough that it'll overflow the address bar) from the URL bar dropdown by middle-clicking it)

AR:
The host name will have the fading effect on it.

ER:
The fading effect should be applied on the last visible characters of the URL.

See attached screencast.

2018-09-07T09:47:48: DEBUG : Starting merge handling...
2018-09-07T09:47:48: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=621979b26f697513f06f4c5f2db1d5ee580c4363&full=1
2018-09-07T09:47:49: DEBUG : Found commit message:
Bug 1485746 - Cursor gets reset to start of address bar on window switch. r=adw

This restores the previous behavior where we set the selection only when setting a new different value

Differential Revision: https://phabricator.services.mozilla.com/D4528

2018-09-07T09:47:49: DEBUG : Did not find a branch, checking all integration branches
2018-09-07T09:47:49: INFO : The bisection is done.

Comment 1

[Marco Bonardo [:mak]]

looks like another unmanaged edge case to be investigated

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Primary UI regression.

Comment 3

[Marco Bonardo [:mak]]

Apparently the problem is that we set the selection only on "current", I just restored the old code, but the "current" check doesn't seem to be necessary...

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1489402 - Middle-clicking a link from the address bar dropdown may apply the wrong overflow effect on the URL. r=adw

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9007825 [details]
Bug 1489402 - Middle-clicking a link from the address bar dropdown may apply the wrong overflow effect on the URL. r=adw

Drew Willcoxon :adw has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/031578506842
Middle-clicking a link from the address bar dropdown may apply the wrong overflow effect on the URL. r=adw

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/031578506842

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

Please request Beta approval on this when you get a chance.

Comment 9

[Itiel]

LGTM on latest Nightly.

Comment 10

[Daniel Bodea [:danibodea]]

I can confirm that the issue does not occur on the latest Nightly v64.0a1 (2018-09-12).

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 9007825 [details]
Bug 1489402 - Middle-clicking a link from the address bar dropdown may apply the wrong overflow effect on the URL. r=adw

Approval Request Comment
[Feature/Bug causing the regression]: bug 1485746
[User impact if declined]: wrong overflow when middle clicking results in the address bar popup, important parts of the url may not be visible
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, str are in omment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial and contained patch
[String changes made/needed]: none

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9007825 [details]
Bug 1489402 - Middle-clicking a link from the address bar dropdown may apply the wrong overflow effect on the URL. r=adw

Contained patch fixing a 63 regression, uplift approved for 63 beta 7, thanks.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec22c8843396

Comment 14

[Daniel Bodea [:danibodea]]

I have reproduced the issue in Beta 5 v63.0b5 and verified the fix in beta 7 v63.0b7 on Windows 10.
Uplift successful.