1489430 - The “Remove Extension” context menu item is not available for pageAction

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[CosminB]

Attachment: pageAction.gif

[Affected versions]:
- Firefox 64.0a1(20180906232139)
- Firefox 63.b04(20180906162647)
- Firefox 62.0(20180830143136)

[Affected platforms]:
- Win 7 64-bit
- Mac OS X 10.13.3

[Steps to reproduce]:
1.Install some extensions that use pageAction.
2.Right-click on the pageAction icon.
3.Observe there is no “Remove Extension” option.

[Expected results]:
- The “Remove Extension” context menu item to be present in the context menu.

[Actual results]:
- The “Remove Extension” context menu item is only available for the browserAction icon.

Please see the attached video.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hey Will, thanks for taking this issue, here is some pointers that may be useful to find some of the relevant pieces:

• the pageAction context menu item actions are defined in browser/base/content/browser-pageActions.js, e.g. here is the action for "Manage Extension"

• the pageAction localized strings are defined in the browser.ftl fluent file

• the pageAction HTML DOM elements are defined in browser.xhtml

• the browserAction's "Remote Extension" context menu item is currently defined here

I think that the pageAction would likely have to do most of what ToolbarContextMenu.removeExtensionForContextAction is doing for the browserAction context menu item, and so it would be great if we could share at least part of the code to handle the extension context menu item shared by both pageAction and browserAction (Mark Striemer may help you to evaluate that or find someone from Firefox Frontend that would be good to consult on the topic).

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/526c65b7b516
Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/526c65b7b516