1489605 - Disable e10s for OLDJAWS users on Firefox 60ESR using sytem addon.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Plan document: 

https://docs.google.com/document/d/1PbEmGK4FzOub54MF3C2hn9NURXMQPGBgI2rgG42CJf8/edit#

Looks like the fastest option forward is Option 2.
We can use system add-on we can to disable e10s for old jaws users upgraded to 60 on the ESR channel.

Here's the pull request for the system add-on that I managed to confirm working on my local machine with JAWS16 installed: 

https://github.com/mozilla/one-off-system-add-ons/pull/126

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Robert, my plan is to, once the PR is good to be merged in, to email release drivers and pi steps.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: jaws-esr.xpi

This is an unsigned xpi that contains l10n bundles.
Rob, would you know who could help with signing this legacy add-on?

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

@jthomas or @wezhou would you be able to help with signing this add-on?

Comment 4

[:wezhou]

Attachment: signed.9008755.xpi

Signed file attached. Please test.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to :wezhou from comment #4)
> Created attachment 9008832 [details]
> signed.9008755.xpi
> 
> Signed file attached. Please test.

Hi Rehan, could you help with staging this and puting it on a Balrog test channel for QA purposes?

Comment 6

[Rehan Dalal (Inactive)]

Hi Yura, could you please confirm which channel (release/beta/nightly) this needs to go out to and I can put it in the appropriate test channel. I also need to know which version(s) we are targeting.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Rehan Dalal [:rehan, :rdalal] from comment #6)
> Hi Yura, could you please confirm which channel (release/beta/nightly) this
> needs to go out to and I can put it in the appropriate test channel. I also
> need to know which version(s) we are targeting.

This is going to be deployed on ESR release, currently, which is 60.2 afaik.

Comment 8

[Rehan Dalal (Inactive)]

This is now on the test channel (esr-sysaddon) for 60.*

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1489605 - include jaws-esr add-on that disables e10s for users of old JAWS screen reader. r=rhelmer

MozReview-Commit-ID: 4J1BlVjo0Zs

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 9010048 [details]
Bug 1489605 - include jaws-esr add-on that disables e10s for users of old JAWS screen reader. r=rhelmer

Robert Helmer [:rhelmer] has approved the revision.

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Also, signed add-on test plan and results: https://docs.google.com/document/d/1hpcu_q1Af_j2t4VShUmvOuNi5XeRGaBHYBwj2JMaVdo/edit?usp=sharing

Comment 12

[Julien Cristau [:jcristau]]

For the record, the system add-on shipped to esr users on balrog at 15:30 UTC today.

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9010048 [details]
Bug 1489605 - include jaws-esr add-on that disables e10s for users of old JAWS screen reader. r=rhelmer

If this is not a sec:{high,crit} bug, please state case for ESR consideration: We deployed a system add-on to disable e10s for users of old JAWS screen reader. This is a next version of the add-on that is now going to be in tree, for cases when old JAWS users install a fresh version of the Firefox 60ESR
User impact if declined: Old JAWS screen reader users that will install a fresh version of 60ESR will have a broken browser until the add-on gets deployed by barlog.
Fix Landed on Version: Old JAWS screen reader is no longer supported with e10s, no plan for fix in later revisions.
Risk to taking this patch (and alternatives if risky): The original version of the add-on was already QA'ed by the PI team, this is just an in-tree version.
String or UUID changes made by this patch: all strings are localized and bundles together with the add-on.

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Try push with L10n-Rpk jobs for 'it' and 'pt-BR' locales as samples: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94c0a457f4147417f250781c92ba921b680717dd

Comment 15

[Axel Hecht [:Pike]]

This is tricky. Right now, the linux builds are broken, as they don't include jaws. We want the language packs to be platform independent, so including the jaws strings in the build on all platforms is important.

I don't have a good idea how to ensure that the build system is there and can package jaws in the langpack w/out actually bundling it on all platforms.

The additional jobs I triggered to ensure that locales w/out jaws add-on build succeeded on windows, though, so we're getting closer.

Comment 16

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9010048 [details]
Bug 1489605 - include jaws-esr add-on that disables e10s for users of old JAWS screen reader. r=rhelmer

Try results look good, approved for ESR 60.2.1.

Comment 17

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/cfd39eb278bb

Comment 18

[Yura Zenevich [:yzen] (please use "needinfo")]

This has landed in ESR60 first as a system add-on as then as part of 60.2.1