Closed Bug 1489662 Opened 2 years ago Closed 2 years ago

Port bug 1408360 to TB: [CSD] The CSD rendered by GTK have sharp corners

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Platform:
All
Linux
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 64.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

Linux-rounded-titlebar.patch
1.50 KB, patch
darktrojan
: review+
Details | Diff | Splinter Review
corner.png
12.44 KB, image/png
Details 
Due to GDK_DECOR_BORDER mShell decoration type the corners have sharp and not rounded corners.
Port of https://hg.mozilla.org/mozilla-central/rev/e7ce94bb130b

Differently to FX I had to add a background-image to not make the statusbar transparent.

I hope you have a distro which uses rounded corners on the titlebar. To test this you can set mozilla.widget.use-argb-visuals to true and then restart TB.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9007387 - Flags: review?(geoff)
Attached image corner.png — 
Unfortunately on my system (Ubuntu 16.04) there's still a problem with the window drop-shadow not being drawn inside the rectangle, but the corner is actually transparent, and Firefox has the same problem, so I'll still give you your r+.
Attachment #9007387 - Flags: review?(geoff) → review+
Thanks. Maybe you could file a bug in Widget: GTK.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4eec6def8a10
Port bug 1408360 to TB: Make toplevel window transparent when mozilla.widget.titlebar-theme-round-corners is set. r=darktrojan
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.