1489765 - Remove getBoolPref function from utilityOverlay.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1482200 +++

Now that Services.prefs.getBoolPref takes a default value, we should be able to call that instead of the getBoolPref function from utilityOverlay.js:

https://searchfox.org/mozilla-central/search?q=+getBoolPref&case=true&path=browser%2Fbase

Comment 1

[Preeti[:preeti]]

Hello! May I please work on this bug if no one else is working on it?
To solve this bug, precisely:
1. I need to delete the function named "getBoolPref(prefname, def)" in browser/base/content/utilityOverlay.js
2. Replace all occurences of getBoolPref by Services.prefs.getBoolPref in browser/base/content/utilityOverlay.js and browser/base/content/browser.js

Thanks in advance!

Comment 2

[Dão Gottwald [:dao]]

(In reply to Preeti[:preeti] from comment #1)
> Hello! May I please work on this bug if no one else is working on it?
> To solve this bug, precisely:
> 1. I need to delete the function named "getBoolPref(prefname, def)" in
> browser/base/content/utilityOverlay.js
> 2. Replace all occurences of getBoolPref by Services.prefs.getBoolPref in
> browser/base/content/utilityOverlay.js and browser/base/content/browser.js
> 
> Thanks in advance!

Yep, exactly. :)

Comment 3

[Preeti[:preeti]]

Attachment: Bug#1489765-Remove getBoolPref function from utilityOverlay.js;r?dao

MozReview-Commit-ID: 2PBUG8yQIXY

Bug#1489765-Remove getBoolPref function from utilityOverlay.js;r?dao

Comment 4

[Preeti[:preeti]]

I have submitted a patch for this bug, please do tell me if I need to incorporate some further changes!

Comment 5

[Dão Gottwald [:dao]]

There's some more code to remove in browser/base/content/test/contextMenu/browser_utilityOverlay.js.

Also, your patch contains unrelated changes in devtools/.

Comment 6

[Preeti[:preeti]]

(In reply to Dão Gottwald [::dao] from comment #5)
> There's some more code to remove in
> browser/base/content/test/contextMenu/browser_utilityOverlay.js.
But I do not have this file in the cloned repository :

preeti@preeti-Inspiron-5577:~/mozilla-central/browser/base/content/test/contextMenu$ ls
browser_contextmenu_linkopen.js  subtst_contextmenu_webext.html
browser_contextmenu_touch.js     test_contextmenu_links.html
browser.ini

Please help.

Comment 7

[Dão Gottwald [:dao]]

browser_utilityOverlay.js was only added a few weeks ago. Is your repository clone up to date?

Comment 8

[Preeti[:preeti]]

(In reply to Dão Gottwald [::dao] from comment #7)
> browser_utilityOverlay.js was only added a few weeks ago. Is your repository
> clone up to date?

I tried to up to date my repository, but I am still getting the following output:

preeti@preeti-Inspiron-5577:~/mozilla-central$ hg pull https://hg.mozilla.org/mozilla-central
pulling from https://hg.mozilla.org/mozilla-central
applying clone bundle from https://hg.cdn.mozilla.net/mozilla-central/4df1ba9c741f1cb6661d9f205ad0fedf91d31925.zstd-max.hg
adding changesets
adding manifests                                                                
adding file changes                                                             
added 435325 changesets with 2751623 changes to 461877 files                    
finished applying clone bundle
searching for changes
no changes found
preeti@preeti-Inspiron-5577:~/mozilla-central$ cd browser/base/content/test/contextMenu/
preeti@preeti-Inspiron-5577:~/mozilla-central/browser/base/content/test/contextMenu$ ls
browser_contextmenu_linkopen.js  subtst_contextmenu_webext.html
browser_contextmenu_touch.js     test_contextmenu_links.html
browser.ini

Please do let me know on how to proceed.

Comment 9

[Dão Gottwald [:dao]]

Not sure what's going on, maybe make a fresh mozilla-central clone?

Comment 10

[Preeti[:preeti]]

Attachment: Bug#1489765-Remove getBoolPref function from utilityOverlay.js;r?dao

Remove getBoolPref function from utilityOverlay.js

Comment 11

[Preeti[:preeti]]

(In reply to Dão Gottwald [::dao] from comment #9)
> Not sure what's going on, maybe make a fresh mozilla-central clone?

I have sumitted a new patch as per your suggestion. Please do review and tell me for further improvements!

Comment 12

[Preeti[:preeti]]

I have submitted another patch with the required changes earlier today. Please do let me know if I need to incorporate any further changes!

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 9007847 [details]
Bug#1489765-Remove getBoolPref function from utilityOverlay.js;r?dao

Dão Gottwald [::dao] has approved the revision.

Comment 14

[Dão Gottwald [:dao]]

I pushed this to the try server to run the mochitest-browser-chrome testsuite:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=75b050f2b0db4795e452e3bf45ef472ab26e0bbf

All green, no failures. Good job!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cdb4bb1282f
Remove getBoolPref function from utilityOverlay.js. r=dao

Comment 16

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3cdb4bb1282f