1489788 - Port Bug 1489787: replace XPCOM use of nsComposeTxtSrvFilter

Status: RESOLVED FIXED

(MailNews Core :: Composition, task)

Description

[Jorg K (CEST = GMT+2)]

See bug 1489787 comment #0.

Comment 1

[(no longer active)]

For a sample code of the necessary change, see https://phabricator.services.mozilla.com/D5353#change-NV6Dun4rb9h6.

FILTERTYPE_NORMAL can be used where @mozilla.org/editor/txtsrvfilter;1 was used before.

FILTERTYPE_MAIL can be used where @mozilla.org/editor/txtsrvfiltermail;1 was used before.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1489788-spellcheck-filter-1.diff

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9007709 [details] [diff] [review]
1489788-spellcheck-filter-1.diff

Review of attachment 9007709 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/ui/dialogs/content/EdSpellCheck.js
@@ +38,5 @@
>      var skipBlockQuotes = window.arguments[1];
>      var enableSelectionChecking = window.arguments[2];
>  
> +    if (skipBlockQuotes) {
> +      filterContractId = FILTERTYPE_MAIL;

Is this going to work? Shouldn't it be:
nsIEditorSpellCheck.FILTERTYPE_MAIL; ?
See const unsigned long FILTERTYPE_NORMAL = 1; in nsIEditorSpellCheck.idl.

Comment 4

[Geoff Lankow (:darktrojan)]

Oh. Um, oops.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1489788-spellcheck-filter-2.diff

I got distracted by the thought that I could use a unary operator, then deciding against it. Would've been fine if I'd used quotes.

Comment 6

[Geoff Lankow (:darktrojan)]

Ternary operator. Yeesh.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9007720 [details] [diff] [review]
1489788-spellcheck-filter-2.diff

Thanks, once again we have to coordinate with bug 1489787.

Comment 8

[(no longer active)]

As a heads-up, I just landed the m-c patches on inbound...

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1489788-spellcheck-filter-2.diff (JK)

Did I hear "ternary" ;-) - I think this looks better and gets rid of the incorrect variable name 'filterContractId'.

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: 1489788-spellcheck-filter-2.diff (JK, v2)

Oops, unused variable.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5b512cb296c7
Port Bug 1489787: replace XPCOM use of nsComposeTxtSrvFilter. r=jorgk