Closed Bug 1489788 Opened Last year Closed Last year

Port Bug 1489787: replace XPCOM use of nsComposeTxtSrvFilter

Categories

(MailNews Core :: Composition, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk, Assigned: darktrojan)

References

Details

Attachments

(1 file, 3 obsolete files)

For a sample code of the necessary change, see https://phabricator.services.mozilla.com/D5353#change-NV6Dun4rb9h6.

FILTERTYPE_NORMAL can be used where @mozilla.org/editor/txtsrvfilter;1 was used before.

FILTERTYPE_MAIL can be used where @mozilla.org/editor/txtsrvfiltermail;1 was used before.
Flags: needinfo?(geoff)
Attached patch 1489788-spellcheck-filter-1.diff (obsolete) — Splinter Review
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9007709 - Flags: review?(jorgk)
Comment on attachment 9007709 [details] [diff] [review]
1489788-spellcheck-filter-1.diff

Review of attachment 9007709 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/ui/dialogs/content/EdSpellCheck.js
@@ +38,5 @@
>      var skipBlockQuotes = window.arguments[1];
>      var enableSelectionChecking = window.arguments[2];
>  
> +    if (skipBlockQuotes) {
> +      filterContractId = FILTERTYPE_MAIL;

Is this going to work? Shouldn't it be:
nsIEditorSpellCheck.FILTERTYPE_MAIL; ?
See const unsigned long FILTERTYPE_NORMAL = 1; in nsIEditorSpellCheck.idl.
Oh. Um, oops.
Attached patch 1489788-spellcheck-filter-2.diff (obsolete) — Splinter Review
I got distracted by the thought that I could use a unary operator, then deciding against it. Would've been fine if I'd used quotes.
Attachment #9007709 - Attachment is obsolete: true
Attachment #9007709 - Flags: review?(jorgk)
Attachment #9007720 - Flags: review?(jorgk)
Ternary operator. Yeesh.
Comment on attachment 9007720 [details] [diff] [review]
1489788-spellcheck-filter-2.diff

Thanks, once again we have to coordinate with bug 1489787.
Attachment #9007720 - Flags: review?(jorgk) → review+
Version: 24 → Trunk
As a heads-up, I just landed the m-c patches on inbound...
Did I hear "ternary" ;-) - I think this looks better and gets rid of the incorrect variable name 'filterContractId'.
Attachment #9007720 - Attachment is obsolete: true
Attachment #9007801 - Flags: review+
Oops, unused variable.
Attachment #9007801 - Attachment is obsolete: true
Attachment #9007842 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5b512cb296c7
Port Bug 1489787: replace XPCOM use of nsComposeTxtSrvFilter. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.